Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Add catch-all type-check target and src dirs #34014

Merged
merged 4 commits into from
Apr 26, 2021

Conversation

rcebulko
Copy link
Contributor

No description provided.

@rcebulko rcebulko requested a review from samouri April 26, 2021 19:19
@amp-owners-bot amp-owners-bot bot requested a review from rsimha April 26, 2021 19:19
Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this!

build-system/tasks/check-types.js Show resolved Hide resolved
srcGlobs: ['src/polyfills{,/**}/*.js'],
warningLevel: 'QUIET',
},
'src-polyfillstub': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd combine this with src-polyfills

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two steps ahead of ya: #34020
Will update whichever one gets submitted second.

build-system/tasks/check-types.js Show resolved Hide resolved
@rcebulko rcebulko merged commit 0c591bd into ampproject:main Apr 26, 2021
@rcebulko rcebulko deleted the pride-check branch April 26, 2021 22:06
@rcebulko rcebulko linked an issue May 12, 2021 that may be closed by this pull request
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
* Add catch-all type-check target and src dirs

* Drop accidental array

* Drop empty arrays and extra function wrappers

* Add temp comment per request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I2I: Restoring AMP’s Type Checking
4 participants