✅ [AMP Story] [Page attachments] Update visual tests for new UIs

build-system/test-configs/config.js

@@ -440,7 +440,6 @@ const htmlFixtureGlobs = [
   '!examples/visual-tests/amp-story/amp-story-grid-layer-template-horizontal.html',
   '!examples/visual-tests/amp-story/amp-story-grid-layer-template-thirds.html',
   '!examples/visual-tests/amp-story/amp-story-grid-layer-template-vertical.html',
-  '!examples/visual-tests/amp-story/amp-story-inline-page-attachment-dark-theme.html',
   '!examples/visual-tests/amp-story/amp-story-interactive-quiz-sizing-positioning.html',
   '!examples/visual-tests/amp-story/amp-story-landscape-templates.html',
   '!examples/visual-tests/amp-story/amp-story-page-attachment.html',

examples/visual-tests/amp-story/amp-story-page-attachment.html

@@ -49,23 +49,114 @@
         poster-landscape-src="/examples/visual-tests/picsum.photos/image981_1600x900.jpg"
         poster-square-src="/examples/visual-tests/picsum.photos/image981_1600x1600.jpg"
         supports-landscape>
-      <amp-story-page id="cover">
+      <amp-story-page id="inline-default">
         <amp-story-page-attachment layout="nodisplay">
           <h1>Some really cool video</h1>
           <p>
-            Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
+            Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
           </p>
-          <amp-video width="auto" height="270" autoplay src="/examples/visual-tests/video/tokyo.mp4" controls>
-          </amp-video>
+        </amp-story-page-attachment>
+      </amp-story-page>
+
+      <amp-story-page id="inline-custom-text">
+        <amp-story-page-attachment
+          layout="nodisplay"
+          cta-text="Custom text">
+          <h1>Some really cool video</h1>
+          <p>
+            Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
+          </p>
+        </amp-story-page-attachment>
+      </amp-story-page>
+
+      <amp-story-page id="inline-dark-theme">
+        <amp-story-page-attachment
+          layout="nodisplay"
+          theme="dark">
+          <h1>Some really cool video</h1>
+          <p>
+            Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
+          </p>
+        </amp-story-page-attachment>
+      </amp-story-page>
+
+      <amp-story-page id="inline-dark-theme-1-image">
+        <amp-story-page-attachment
+          title="Lorem ipsum"
+          layout="nodisplay"
+          cta-image="noimage"
+          theme="dark"
+          >
+          <h1>Some really cool video</h1>
+          <p>
+            Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
+          </p>
+        </amp-story-page-attachment>
+      </amp-story-page>
+
+      <amp-story-page id="inline-dark-theme-2-images">
+        <amp-story-page-attachment
+          title="Lorem ipsum"
+          layout="nodisplay"
+          cta-image="noimage"
+          cta-image-2="noimage"
+          theme="dark"
+          >
+          <h1>Some really cool video</h1>
           <p>
-            Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam, eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae vitae dicta sunt explicabo. Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt. Neque porro quisquam est, qui dolorem ipsum quia dolor sit amet, consectetur, adipisci velit, sed quia non numquam eius modi tempora incidunt ut labore et dolore magnam aliquam quaerat voluptatem. Ut enim ad minima veniam, quis nostrum exercitationem ullam corporis suscipit laboriosam, nisi ut aliquid ex ea commodi consequatur? Quis autem vel eum iure reprehenderit qui in ea voluptate velit esse quam nihil molestiae consequatur, vel illum qui dolorem eum fugiat quo voluptas nulla pariatur?
+            Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
           </p>
         </amp-story-page-attachment>
       </amp-story-page>
-      <amp-story-page id="page-2">
+
+      <amp-story-page id="outlink-default">
         <amp-story-page-attachment layout="nodisplay" href="https://google.com">
         </amp-story-page-attachment>
       </amp-story-page>
+
+      <amp-story-page id="outlink-custom-text">
+        <amp-story-page-attachment
+          layout="nodisplay"
+          href="https://google.com"
+          cta-text="Custom text">
+        </amp-story-page-attachment>
+      </amp-story-page>
+
+      <amp-story-page id="outlink-no-image">
+        <amp-story-page-attachment
+          layout="nodisplay"
+          href="https://google.com"
+          cta-image="none">
+        </amp-story-page-attachment>
+      </amp-story-page>
+
+      <amp-story-page id="outlink-dark-theme">
+        <amp-story-page-attachment
+          layout="nodisplay"
+          href="https://google.com"
+          theme="dark">
+        </amp-story-page-attachment>
+      </amp-story-page>
+
+      <amp-story-page id="outlink-custom-background">
+        <amp-story-page-attachment
+          layout="nodisplay"
+          href="https://google.com"
+          theme="custom"
+          cta-accent-color="pink"
+          cta-accent-element="background">
+        </amp-story-page-attachment>
+      </amp-story-page>
+
+      <amp-story-page id="outlink-custom-background">
+        <amp-story-page-attachment
+          layout="nodisplay"
+          href="https://google.com"
+          theme="custom"
+          cta-accent-color="pink"
+          cta-accent-element="text">
+        </amp-story-page-attachment>
+      </amp-story-page>
     </amp-story>
   </body>
 </html>

test/visual-diff/visual-tests

@@ -878,17 +878,6 @@
       "name": "amp-story-360: 360 image rendering",
       "viewport": {"width": 320, "height": 480},
       "loading_complete_selectors": [".i-amphtml-story-360-loaded"]
-    },
-    {
-      "url": "examples/visual-tests/amp-story/amp-story-inline-page-attachment-dark-theme.html",
-      "name": "amp-story-inline-page-attachment-dark-theme: displays new inline CTA button with dark theme",
-      "viewport": {"width": 320, "height": 480},
-      "loading_complete_selectors": [
-        ".i-amphtml-story-loaded",
-        "amp-story-page#cover[active]"
-      ],
-      // for page navigation
-      "loading_complete_delay_ms": 500
     }
   ]
 }