♻️ Support absolute import paths

[rcebulko]

Adopts an alias configuration very similar to NuxtJS:

• @/ maps to the project root (import {dev, user} from '@/src/log')
• @@/ maps to shared core (import {dict} from '@@/types/object')

NuxtJS provides 4 standard aliases: @@ and ~~ map to the project root; @ and ~ map to the core source directory. I'm open to either convention, or bikeshedding something else.

Eliminates long strings of '../../../..' (and by extension makes it easier to refactor and move files since imports won't need updating)

[amp-owners-bot]

Hey @alanorozco! These files were changed:

build-system/tasks/storybook/amp-env/webpack.config.js
build-system/tasks/storybook/preact-env/webpack.config.js

Hey @jridgewell! These files were changed:

src/core/assert/base.js
src/core/assert/dev.js
src/core/assert/user.js
src/core/constants/action-constants.js
src/core/data-structures/signals.js
src/core/dom/css.js
src/core/error-message-helpers.js

[samouri]

The updated import statements look lovely!

Unfortunately, it is unclear to me that this is a net-positive.

1. It adds a level of indirection. Just another item which is strange about AMP's build system.
2. Do you know if "Click to Definition" will still work in IDEs? This is a huge convenience while working on the codebase and I'd hate to lose it for shorter lines.

[kristoferbaxter]

I too am a bit mixed for the same reasons Jake mentioned. Would like to hear others thoughts though.

[lgtm-com]

This pull request fixes 7 alerts when merging 7206e5d into a8895fa - view on LGTM.com

fixed alerts:

• 7 for Useless conditional

[rcebulko]

1. It adds a level of indirection. Just another item which is strange about AMP's build system.

@samouri For a more "normal" feel, WDYT about if we used something like @amp/core which would feel more like importing from packages?

2. Do you know if "Click to Definition" will still work in IDEs? This is a huge convenience while working on the codebase and I'd hate to lose it for shorter lines.

This part I do not know offhand and didn't consider. My editor indexes by symbol without using import paths, but perhaps vscode is different?
Edit: VSCode has built-in support via jsconfig.js for aliasing absolute import paths in this way

[lgtm-com]

This pull request fixes 7 alerts when merging 1690c8b into 2e762f0 - view on LGTM.com

fixed alerts:

• 7 for Useless conditional

[alanorozco]

FMI: Does the Webpack config need to be updated somehow? Can Storybook still get files from src/?

[rcebulko]

If I'm understanding your question correctly, yes, Storybook should be able to use absolute imports as well

[lgtm-com]

This pull request fixes 7 alerts when merging f9631c3 into fdad648 - view on LGTM.com

fixed alerts:

• 7 for Useless conditional

[lgtm-com]

This pull request fixes 7 alerts when merging a38ba07 into df5b6a1 - view on LGTM.com

fixed alerts:

• 7 for Useless conditional

[samouri]

Writing to confirm that the jsconfig did alleviate my concerns with VS Code!

[lgtm-com]

This pull request fixes 7 alerts when merging adfbdb1 into df5b6a1 - view on LGTM.com

fixed alerts:

• 7 for Useless conditional