♻️ Another pass at reducing complexity around Log
#35461
Conversation
| @@ -211,7 +180,7 @@ export class Log { | |||
| } | |||
|
|
|||
| // LocalDev by default allows INFO level, unless overriden by `#log`. | |||
| if (getMode().localDev && !getMode().log) { | |||
| if (getMode().localDev) { | |||
There was a problem hiding this comment.
getMode().log == 0 above implies !getMode().log already
| @@ -224,46 +193,40 @@ export class Log { | |||
| */ | |||
| defaultLevelWithFunc_() { | |||
| // Delegate to the specific resolver. | |||
| return this.levelFunc_(parseInt(getMode().log, 10), getMode().development); | |||
| return this.levelFunc_(getMode().log, getMode().development); | |||
There was a problem hiding this comment.
moved parsing into mode
| */ | ||
| isEnabled() { | ||
| return this.getLevel_() != LogLevel.OFF; | ||
| return true; |
There was a problem hiding this comment.
isEnabled wasn't used anywhere.
|
|
||
| return this.messages_?.[id] | ||
| ? [this.messages_[id]].concat(parts) | ||
| : [`More info at ${externalMessageUrl(id, parts)}`]; |
There was a problem hiding this comment.
This code is mostly untouched, but I moved all the assert helpers to the end of the class definition so the rest of the log/error methods were together.
rcebulko
changed the title
LogLog
|
Hey @jridgewell! These files were changed: |
|
@jridgewell bumping this |
|
@rcebulko you are my hero |
| } | ||
|
|
||
| const cs = this.win.console; | ||
| const fn = |
There was a problem hiding this comment.
clever, but IMO harder to read. not b/c the pattern is inherently worse, its just super uncommon
|
|
||
| return this.messages_?.[id] | ||
| ? [this.messages_[id]].concat(parts) | ||
| : [`More info at ${externalMessageUrl(id, parts)}`]; |
There was a problem hiding this comment.
FMI: do you know if this code is actually active? I didn't realize we even had started on this feature
There was a problem hiding this comment.
It has never been used/shipped, but was working (though untested) at one point. The transforms likely need updating since much of assertion code has been moved.
setReportErrortoerror-reporting#core/error/message-helpersLogmethods/constructor helpers