Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attributionsrc on <a /> #38652

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Allow attributionsrc on <a /> #38652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions validator/testdata/amp4ads_feature_tests/anchor_attribution_reporting.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!--
Test Description:
Enable the attribution reporting API for anchor elements
https://github.com/WICG/attribution-reporting-api/blob/main/EVENT.md#api-overview
-->
<!doctype html>
<html ⚡4ads>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width,minimum-scale=1">
<style amp4ads-boilerplate>body{visibility:hidden}</style>
<script async src="https://cdn.ampproject.org/amp4ads-v0.js"></script>
</head>
<body>
Hello, world.
<a attributionsrc></a>
<a attributionsrc="https://adtech.example"></a>
</body>
</html>
20 changes: 20 additions & 0 deletions validator/testdata/amp4ads_feature_tests/anchor_attribution_reporting.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
PASS
| <!--
| Test Description:
| Enable the attribution reporting API for anchor elements
| https://github.com/WICG/attribution-reporting-api/blob/main/EVENT.md#api-overview
| -->
| <!doctype html>
| <html ⚡4ads>
| <head>
| <meta charset="utf-8">
| <meta name="viewport" content="width=device-width,minimum-scale=1">
| <style amp4ads-boilerplate>body{visibility:hidden}</style>
| <script async src="https://cdn.ampproject.org/amp4ads-v0.js"></script>
| </head>
| <body>
| Hello, world.
| <a attributionsrc></a>
| <a attributionsrc="https://adtech.example"></a>
| </body>
| </html>
7 changes: 7 additions & 0 deletions validator/validator-main.protoascii
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1347,6 +1347,13 @@ tags: {
html_format: AMP
html_format: AMP4ADS
tag_name: "A"
attrs: {
name: "attributionsrc"
value_url: {
protocol: "https"
allow_empty: true
}
}
attrs: { name: "border" } # Not valid html5 but commonly used and supported.
attrs: { name: "download" }
attrs: {
Expand Down