Fix lots of type errors and introduces assertElement. #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erwinmombay I apologize for the overlap with your recent change! |
| new AssertionFunctionSpec("module$src$log.user.assert", JSType.TRUTHY), | ||
| new AssertionFunctionSpec("module$src$log.dev.assert", JSType.TRUTHY), | ||
| new AssertionFunctionSpec("Log$$module$src$log.prototype.assert", JSType.TRUTHY) | ||
| new AssertionFunctionSpec("Log$$module$src$log.prototype.assert", JSType.TRUTHY), |
There was a problem hiding this comment.
so we need to change this too to "AssertFunctionByTypeName" ?
There was a problem hiding this comment.
ah nvm, looks like that doesn't work. i was hoping AssertFunctionByTypeName solves the inference issue
There was a problem hiding this comment.
Yeah, this is just an utility to be able to use custom types like Element
- Gets rid of many specific `Element` types. In practice these aren't helpful, but introduce a lot of casting. - Might have fixed on actualy bug in url-replacements.js 142 error(s), 6 warning(s), 93.81603250831178% typed
| @@ -472,14 +472,15 @@ export class UrlReplacements { | |||
| : String(metric); | |||
| }); | |||
| } else { | |||
| return Promise.resolve(String(metric)); | |||
| return /** @type {!Promise<(string|undefined)>} */ ( | |||
There was a problem hiding this comment.
This should just be !Promise<string>.
There was a problem hiding this comment.
Same reason. Unfortunately CC doesn't support complex type equivalencies on generics.
|
LG please :) |
|
LGTM |
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Sep 16, 2016
* Fix lots of type errors and introduces assertElement. - Gets rid of many specific `Element` types. In practice these aren't helpful, but introduce a lot of casting. - Might have fixed on actualy bug in url-replacements.js 142 error(s), 6 warning(s), 93.81603250831178% typed
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
* Fix lots of type errors and introduces assertElement. - Gets rid of many specific `Element` types. In practice these aren't helpful, but introduce a lot of casting. - Might have fixed on actualy bug in url-replacements.js 142 error(s), 6 warning(s), 93.81603250831178% typed
This was referenced Oct 26, 2021
This was referenced Nov 5, 2021
This was referenced Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elementtypes. In practice these aren't helpful, but introduce a lot of casting.142 error(s), 6 warning(s), 93.81603250831178% typed