Migrate timer into shared service. #4961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces most extensions by about 1KB.
| @@ -22,6 +22,8 @@ import {getMode} from '../../src/mode'; | |||
| import {isExperimentOn, toggleExperiment} from '../../src/experiments'; | |||
| import {listenOnce} from '../../src/event-helper'; | |||
| import {onDocumentReady} from '../../src/document-ready'; | |||
| //TODO(@cramforce): For type. Replace with forward declaration. | |||
| import '../../src/service/timer-impl'; | |||
There was a problem hiding this comment.
It makes the compiler happy, because the compilation unit references the type, but not its implementation.
I will soon implement a more general solution to this problem.
|
Want to work on |
|
@jridgewell Maybe when I'm bored. |
|
LGTM |
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Sep 16, 2016
Reduces most extensions by about 1KB.
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
Reduces most extensions by about 1KB.
This was referenced Oct 11, 2021
This was referenced Nov 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces most extensions by about 1KB.