fix(tool): add asserts to changelog code to make it less fragile. #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
changelog-assert
branch
2 times, most recently
from
3be4260 to
3ff2d90
Compare
| @@ -69,6 +70,7 @@ function getGitMetadata() { | |||
| } | |||
|
|
|||
| function submitReleaseNotes(version, changelog) { | |||
| assert(typeof version == 'number', 'version should be a number.'); | |||
There was a problem hiding this comment.
Here and elsewhere output the broken value into the assert.
erwinmombay
force-pushed
the
changelog-assert
branch
from
3ff2d90 to
fd703c8
Compare
erwinmombay
force-pushed
the
changelog-assert
branch
from
fd703c8 to
de6af6c
Compare
| return submitReleaseNotes(version, gitMetadata.changelog); | ||
| }) | ||
| .catch(errHandler); | ||
| } | ||
|
|
||
| function submitReleaseNotes(version, changelog) { | ||
| assert(typeof version == 'number', 'version should be a number. ' + version); |
|
LGTM with one comment |
erwinmombay
added a commit
that referenced
this pull request
Nov 20, 2015
fix(tool): add asserts to changelog code to make it less fragile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.