Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided a tutorial for RabbitMq priority queue implementation #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

girirajsharma
Copy link

I have observed RabbitMq tutorials for different client's are quite consistent i.e., exactly same tutorials are available for all client's. Updating/adding tutorial of one of the client possibly requires porting the exact same tutorial for all other client's

Therefore, I would be happy to issue following PR's step wise as follow-up commits:

  1. Porting the same tutorial for Javascript (with Node and amqp-node) (using promises/futures)
  2. Porting the same tutorial for all RabbitMq clients with a separate PR for each client in step-wise order.
  3. If feasible and applicable, porting the tutorial demonstration over official RabbitMq website in step-wise order for supported client's as such the website source is open.

Please correct me if above idea(s) doesn't really make sense or is(are) not applicable.

@girirajsharma
Copy link
Author

No idea why it fails on Node.js~0.9 and passes on all other versions.

@squaremo
Copy link
Collaborator

Thanks for the PR 👍

You should really put the idea of a priority queue tutorial to the RabbitMQ developers (maybe via https://groups.google.com/forum/#!forum/rabbitmq-users). They will probably want to have some text to go along with it, but maybe you could collaborate on that if they like the idea.

In the meantime, I welcome example code -- could you perhaps put send and receive in the same file, and move it to examples/?

@girirajsharma
Copy link
Author

Yeah, I will be pushing the idea on the suggested forum and will act accordingly. Infact, I am on it :)

It's fine to move the code to examples/ but i din't get putting send and receive in the same file. Isn't it better to keep them separate like all other tutorials.

Base automatically changed from master to main February 17, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants