Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc/ @kubouch
in this PR, the rendering of data with rows will only compute the rendered strings for the rows in the frame.
from what i've seen, it looks like it allows to run
nu_plugin_explore
on data longer by around an order of magnitude 🤔seq 1 100_000 | nu_plugin_explore
is already pretty slow (slower than withseq 1 1_000_000
below)seq 1 1_000_000 | nu_plugin_explore
is absolutely unusableseq 1 100_000 | nu_plugin_explore
is very responsiveseq 1 1_000_000 | nu_plugin_explore
starts to feel a bit slowseq 1 10_000_000 | nu_plugin_explore
starts to be very slow, sometimes it does not even respond andnu_plugin_explore
took ages to start (i'm wondering if the plugin has to collect before starting, and collectingbonus
this PR also fixes the height of the frame in the compact layout, making it consistent with the table layout and the rendering style of true tables.