Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve long data performance #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amtoine
Copy link
Owner

@amtoine amtoine commented Jul 14, 2024

cc/ @kubouch

in this PR, the rendering of data with rows will only compute the rendered strings for the rows in the frame.

from what i've seen, it looks like it allows to run nu_plugin_explore on data longer by around an order of magnitude 🤔

  • before this PR
    • seq 1 100_000 | nu_plugin_explore is already pretty slow (slower than with seq 1 1_000_000 below)
    • seq 1 1_000_000 | nu_plugin_explore is absolutely unusable
  • with this PR
    • seq 1 100_000 | nu_plugin_explore is very responsive
    • seq 1 1_000_000 | nu_plugin_explore starts to feel a bit slow
    • seq 1 10_000_000 | nu_plugin_explore starts to be very slow, sometimes it does not even respond and nu_plugin_explore took ages to start (i'm wondering if the plugin has to collect before starting, and collecting $10^{7}$ items might be pretty slow)

bonus

this PR also fixes the height of the frame in the compact layout, making it consistent with the table layout and the rendering style of true tables.

@amtoine
Copy link
Owner Author

amtoine commented Jul 14, 2024

would be great to have some benchmarks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant