Fixing null check

Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
amundsen-io · Aug 28, 2020 · 6966f45 · 6966f45
1 parent 0a0fe32
commit 6966f45
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/amundsen_application/static/.betterer.results b/amundsen_application/static/.betterer.results
@@ -113,18 +113,18 @@ exports[`strict null compilation`] = {
       [171, 6, 3, "Type \'string\' is not assignable to type \'never\'.", "193424690"],
       [172, 6, 5, "Type \'string\' is not assignable to type \'never\'.", "183222373"],
       [182, 8, 7, "Type \'Element\' is not assignable to type \'never\'.", "3716929964"],
-      [183, 11, 26, "Type \'{ itemsPerPage: number; source: string; }\' is missing the following properties from type \'Readonly<Pick<TableDashboardResourceListProps, \\"source\\" | \\"dashboards\\" | \\"isLoading\\" | \\"errorText\\" | \\"itemsPerPage\\"> & OwnProps>\': dashboards, isLoading, errorText", "2224258167"],
+      [183, 11, 26, "Type \'{ itemsPerPage: number; source: string; }\' is missing the following properties from type \'Readonly<Pick<TableDashboardResourceListProps, \\"source\\" | \\"isLoading\\" | \\"dashboards\\" | \\"errorText\\" | \\"itemsPerPage\\"> & OwnProps>\': isLoading, dashboards, errorText", "2224258167"],
       [188, 8, 3, "Type \'string\' is not assignable to type \'never\'.", "193424690"],
       [189, 8, 5, "Type \'string | Element\' is not assignable to type \'never\'.\\n  Type \'string\' is not assignable to type \'never\'.", "183222373"],
       [263, 16, 7, "Type \'string | null\' is not assignable to type \'string | undefined\'.\\n  Type \'null\' is not assignable to type \'string | undefined\'.", "3817619378"],
       [305, 20, 35, "Argument of type \'ProgrammaticDescription[] | undefined\' is not assignable to parameter of type \'ProgrammaticDescription[]\'.\\n  Type \'undefined\' is not assignable to type \'ProgrammaticDescription[]\'.", "4249007202"],
       [319, 20, 36, "Argument of type \'ProgrammaticDescription[] | undefined\' is not assignable to parameter of type \'ProgrammaticDescription[]\'.\\n  Type \'undefined\' is not assignable to type \'ProgrammaticDescription[]\'.", "2770872537"],
       [324, 16, 36, "Argument of type \'ProgrammaticDescription[] | undefined\' is not assignable to parameter of type \'ProgrammaticDescription[]\'.\\n  Type \'undefined\' is not assignable to type \'ProgrammaticDescription[]\'.", "2776557981"]
     ],
-    "js/components/common/Announcements/AnnouncementsList/index.spec.tsx:1710887993": [
-      [95, 23, 124, "Object is possibly \'null\'.", "4248337497"]
+    "js/components/common/Announcements/AnnouncementsList/index.spec.tsx:1395073325": [
+      [94, 23, 124, "Object is possibly \'null\'.", "4248337497"]
     ],
-    "js/components/common/Announcements/AnnouncementsList/index.tsx:1484765516": [
+    "js/components/common/Announcements/AnnouncementsList/index.tsx:3478884749": [
       [70, 4, 11, "Type \'Element\' is not assignable to type \'null\'.", "3768376622"],
       [73, 4, 11, "Type \'Element[]\' is not assignable to type \'null\'.", "3768376622"],
       [85, 4, 11, "Type \'Element\' is not assignable to type \'null\'.", "3768376622"],

diff --git a/amundsen_application/static/js/components/common/Alert/index.tsx b/amundsen_application/static/js/components/common/Alert/index.tsx
@@ -24,7 +24,7 @@ const Alert: React.FC<AlertProps> = ({
   actionHref,
   actionLink,
 }: AlertProps) => {
-  let action = null;
+  let action: null | React.ReactNode = null;
 
   if (actionText && onAction) {
     action = (