Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration.md #583

Closed
wants to merge 1 commit into from
Closed

Conversation

mkrajaci
Copy link

fix: the wrong link to documentation files

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

fix: the wrong link to documentation files
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for this!

@Golodhros
Copy link
Member

@mkrajaci You would need to follow the steps regarding the DCO sign off, check on the "details" link up there.

@ttannis
Copy link
Contributor

ttannis commented Aug 21, 2020

bump @mkrajaci for the DCO check

@mkrajaci
Copy link
Author

I will check it, thanks @ttannis

@mkrajaci
Copy link
Author

mkrajaci commented Aug 26, 2020

@ttannis could you help me? After entering this git push --force-with-lease origin pr/583 in the terminal I get an error: error: src refspec pr/583 does not match any
error: failed to push some refs to 'git@github.com:amundsen-io/amundsen.git'
I did all the requirements and even created new local branch

@Golodhros
Copy link
Member

@ttannis could you help me? After entering this git push --force-with-lease origin pr/583 in the terminal I get an error: error: src refspec pr/583 does not match any
error: failed to push some refs to 'git@github.com:amundsen-io/amundsen.git'
I did all the requirements and even created new local branch

Interesting, I would guess the right command would be git push --force-with-lease origin patch-1

@mkrajaci
Copy link
Author

mkrajaci commented Aug 27, 2020

This is the right command: git push --force-with-lease origin mkrajaci_patch_2 but after that a get another error:

ERROR: Permission to amundsen-io/amundsen.git denied to mkrajaci.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@Golodhros @ttannis do I need some special access rights for this commit?

@Golodhros
Copy link
Member

This is the right command: git push --force-with-lease origin mkrajaci_patch_2 but after that a get another error:

ERROR: Permission to amundsen-io/amundsen.git denied to mkrajaci.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@Golodhros @ttannis do I need some special access rights for this commit?

What's the results of running git remote -v for you?

@mkrajaci
Copy link
Author

What's the results of running git remote -v for you?

origin git@github.com:amundsen-io/amundsen.git (fetch)
origin git@github.com:amundsen-io/amundsen.git (push)

@jornh
Copy link
Contributor

jornh commented Sep 1, 2020

@mkrajaci you need to git remote add your own fork where you have write permission (e.g. call it mkrajaci) then perform the force push against the patch-1 branch on that instead of origin so like:

git push --force-with-lease mkrajaci patch-1

It’s patch-1 because that’s what this PR is referencing as you see in the top of #583

@stale
Copy link

stale bot commented Sep 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale stalebot believes this issue/PR is no longer active label Sep 15, 2020
@Golodhros
Copy link
Member

Added on #676

@Golodhros Golodhros closed this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stalebot believes this issue/PR is no longer active
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants