-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration.md #583
Conversation
fix: the wrong link to documentation files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for this!
@mkrajaci You would need to follow the steps regarding the DCO sign off, check on the "details" link up there. |
bump @mkrajaci for the DCO check |
I will check it, thanks @ttannis |
@ttannis could you help me? After entering this git push --force-with-lease origin pr/583 in the terminal I get an error: error: src refspec pr/583 does not match any |
Interesting, I would guess the right command would be |
This is the right command: git push --force-with-lease origin mkrajaci_patch_2 but after that a get another error: ERROR: Permission to amundsen-io/amundsen.git denied to mkrajaci. Please make sure you have the correct access rights @Golodhros @ttannis do I need some special access rights for this commit? |
What's the results of running |
origin git@github.com:amundsen-io/amundsen.git (fetch) |
@mkrajaci you need to
It’s patch-1 because that’s what this PR is referencing as you see in the top of #583 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Added on #676 |
fix: the wrong link to documentation files
Summary of Changes
Include a summary of changes then remove this line
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.