Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moves pages into its own folder #624

Merged
merged 11 commits into from
Aug 31, 2020
Merged

Conversation

Golodhros
Copy link
Member

Summary of Changes

Moves the Pages currently living on the components/ folder into their own pages/ folder
Updates all paths

amundsenfrontend-private

Tests

Ran tests
Tested manually

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

allisonsuarez
allisonsuarez previously approved these changes Aug 31, 2020
Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for doing this!

Copy link
Contributor

@ttannis ttannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're creating a new "top-level" directory, I would expect to see some changes in:

  1. jest.config.js where we set coverage thresholds to ensure our coverage does not get worse. We decided a long time ago that we would aim for at least 75% across all testable code, and every now and then I actually bump the threshold depending on how much we've improved to try to keep in that way. Could you set some thresholds for pages in that file based on what our current coverage happens to be, as well as update the thresholds for components? I usually leave at least 5% buffer, at most 10%.

2.webpack.common where we define paths.

@Golodhros
Copy link
Member Author

Since we're creating a new "top-level" directory, I would expect to see some changes in:

  1. jest.config.js where we set coverage thresholds to ensure our coverage does not get worse. We decided a long time ago that we would aim for at least 75% across all testable code, and every now and then I actually bump the threshold depending on how much we've improved to try to keep in that way. Could you set some thresholds for pages in that file based on what our current coverage happens to be, as well as update the thresholds for components? I usually leave at least 5% buffer, at most 10%.

2.webpack.common where we define paths.

Good catch! Updating those!

…lder

Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
…prettier bug

Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
@Golodhros Golodhros merged commit 319d7fe into master Aug 31, 2020
@ttannis ttannis deleted the mi-file-structure branch September 9, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants