-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Moves pages into its own folder #624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're creating a new "top-level" directory, I would expect to see some changes in:
jest.config.js
where we set coverage thresholds to ensure our coverage does not get worse. We decided a long time ago that we would aim for at least 75% across all testable code, and every now and then I actually bump the threshold depending on how much we've improved to try to keep in that way. Could you set some thresholds forpages
in that file based on what our current coverage happens to be, as well as update the thresholds forcomponents
? I usually leave at least 5% buffer, at most 10%.
2.webpack.common
where we define paths.
Good catch! Updating those! |
…lder Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
…prettier bug Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
c252dbe
to
b1db7d1
Compare
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Summary of Changes
Moves the Pages currently living on the components/ folder into their own pages/ folder
Updates all paths
Tests
Ran tests
Tested manually
CheckList
Make sure you have checked all steps below to ensure a timely review.