-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds expandable feature to table #654
Conversation
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
@@ -91,9 +133,11 @@ const Table: React.FC<TableProps> = ({ | |||
isLoading = false, | |||
numLoadingBlocks = DEFAULT_LOADING_ITEMS, | |||
rowHeight = DEFAULT_ROW_HEIGHT, | |||
expandRow = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected that this isn't and issue for the strictNullChecks
rule, given that this is defined above as an optional Function
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't complain!
Not sure if there is a better option though... happy to try other solutions!
Summary of Changes
Adds expandable rows
Adds fixed width
Splits stories in three sections
Tests
Lots of them
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.