-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Column list with usage column and new reusable table #684
Conversation
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
hey @Golodhros ,
Thanks, will look at more once fully back next week. |
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Well, it is big indeed, but I am confident it won't change a lot of things as it is only adding the usage information to the list. I think we are ready to merge it.
I synced with Daniel about this. We will be showing the usage column if any of the columns have usage information, but if none of them have it, we won't show the usage column.
Oh, I see. You mean with the name of the tab, right? Good call! I will ask Knowl, anyways it will be super easy to change.
Yes, as the 'usage' data is always visible on the top row. Do you feel that's confusing? Maybe we could be more specific and say "Column usage reflects data..."
Open to discussion. I kept the old component around, so it would be easy to have that table back. I didn't love the styling of it though :)
Thanks! I did a walkthrough with Allison today and we tweaked some stuff so we will merge it for now. Also Knowl has some styling tweaks that I will add on the next PR. |
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Summary of Changes
Swaps the current Column list with the new reusable table
Adds the usage column
Updates the reusable table with new features
Updated some icon's greys
Tests
Added tests
Updated coverage settings
Documentation
Added table's stories
CheckList
Make sure you have checked all steps below to ensure a timely review.