Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relaxed marshmallow requirement to see if conflicts arise #697

Merged
merged 3 commits into from
Sep 29, 2020

Conversation

allisonsuarez
Copy link
Contributor

Summary of Changes

CI marshmallow incompatible version conflicts.

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez requested a review from a team as a code owner September 29, 2020 18:02
@allisonsuarez allisonsuarez marked this pull request as draft September 29, 2020 18:02
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for doing this!

@feng-tao
Copy link
Member

it seems marshmallow-annotations needs to change to range as well

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez marked this pull request as ready for review September 29, 2020 18:32
@allisonsuarez allisonsuarez merged commit 7a14f5f into master Sep 29, 2020
@allisonsuarez allisonsuarez deleted the asm-marsh-version branch September 29, 2020 18:33
@feng-tao
Copy link
Member

thanks @allisonsuarez for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants