-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: accept non int stats values #748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
ttannis
reviewed
Nov 2, 2020
amundsen_application/static/js/components/ColumnList/ColumnStats/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez
requested review from
dikshathakur3119,
feng-tao and
Golodhros
as code owners
November 2, 2020 21:11
Golodhros
reviewed
Nov 2, 2020
amundsen_application/static/js/components/ColumnList/ColumnStats/index.tsx
Show resolved
Hide resolved
ttannis
reviewed
Nov 2, 2020
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Golodhros
reviewed
Nov 2, 2020
@@ -135,6 +135,26 @@ function TestDataBuilder(config = {}) { | |||
|
|||
return new this.Klass(attr); | |||
}; | |||
this.withNonNumericStats = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Test Data Builders!
Golodhros
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for taking the time to add those tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changed logic so non numerical stats values will not be converted to int.
amundsen-io/amundsen#778
Tests
test cases where stats values are dates.
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.