Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept non int stats values #748

Merged
merged 5 commits into from
Nov 2, 2020
Merged

fix: accept non int stats values #748

merged 5 commits into from
Nov 2, 2020

Conversation

allisonsuarez
Copy link
Contributor

Summary of Changes

Changed logic so non numerical stats values will not be converted to int.
amundsen-io/amundsen#778

Tests

test cases where stats values are dates.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez marked this pull request as ready for review November 2, 2020 21:11
@allisonsuarez allisonsuarez requested a review from ttannis November 2, 2020 21:11
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@@ -135,6 +135,26 @@ function TestDataBuilder(config = {}) {

return new this.Klass(attr);
};
this.withNonNumericStats = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Test Data Builders!

Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for taking the time to add those tests!

@allisonsuarez allisonsuarez merged commit 49f0996 into master Nov 2, 2020
@allisonsuarez allisonsuarez deleted the asm-stats-fix branch November 2, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants