Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix to display column statics #771

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

bogo96
Copy link
Contributor

@bogo96 bogo96 commented Nov 23, 2020

Signed-off-by: hyein bogo96@kaist.ac.kr

Summary of Changes

  • fix to display column statics datails.

related issue: amundsen-io/amundsen#814

Tests

  • test with sample data(databuilder/example/scripts/sample_data_loader.py
    image

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

Signed-off-by: hyein <hyen.seo@samsung.com>
Copy link
Contributor

@dikshathakur3119 dikshathakur3119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dikshathakur3119 dikshathakur3119 merged commit 23964d1 into amundsen-io:master Nov 23, 2020
@bogo96 bogo96 deleted the display-col-stats branch November 24, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants