Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumped amundsen-common version #795

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Conversation

allisonsuarez
Copy link
Contributor

Summary of Changes

Bumped amundsen-common version which has fix for marshmallow-annotations version.

Tests

n/a

Documentation

n/a

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@dorianj
Copy link
Contributor

dorianj commented Dec 1, 2020

note that this PR is failing CI because master is broken -- once #797 lands, if you rebase off of that, this should pass

@allisonsuarez
Copy link
Contributor Author

note that this PR is failing CI because master is broken -- once #797 lands, if you rebase off of that, this should pass

oooh I didn't realize that thank you :)

@allisonsuarez allisonsuarez marked this pull request as ready for review December 1, 2020 17:18
@allisonsuarez allisonsuarez requested a review from a team as a code owner December 1, 2020 17:18
@allisonsuarez allisonsuarez merged commit a8c9e7a into master Dec 1, 2020
@allisonsuarez allisonsuarez deleted the asm-bump-common branch December 1, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants