Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Add details to inference and serialization documentation #144

Merged
merged 9 commits into from
Feb 20, 2019

Conversation

meissnereric
Copy link
Contributor

@meissnereric meissnereric commented Jan 7, 2019

*Issue #99 , #122, #84 *

Description of changes:
Add a more detailed description of the inference process and machinery.
Add documentation on how serialization works.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #144 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #144   +/-   ##
========================================
  Coverage    85.06%   85.06%           
========================================
  Files           78       78           
  Lines         3898     3898           
  Branches       660      660           
========================================
  Hits          3316     3316           
  Misses         383      383           
  Partials       199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29ea53...49b6d4e. Read the comment docs.

@meissnereric meissnereric changed the title Add details to inference documentation Add details to inference and serialization documentation Jan 10, 2019
Copy link
Contributor

@zhenwendai zhenwendai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We need to make a tutorial notebook to give an example of saving and loading of inference results.
  • Some of the texts need to be updated, once the zipping work is done for serialization.

docs/design_documents/inference.md Outdated Show resolved Hide resolved
docs/design_documents/serialization.md Outdated Show resolved Hide resolved
docs/design_documents/serialization.md Outdated Show resolved Hide resolved
zhenwendai and others added 6 commits February 20, 2019 09:16
Co-Authored-By: meissnereric <meissner.eric.7@gmail.com>
Co-Authored-By: meissnereric <meissner.eric.7@gmail.com>
Co-Authored-By: meissnereric <meissner.eric.7@gmail.com>
Co-Authored-By: meissnereric <meissner.eric.7@gmail.com>
@meissnereric meissnereric merged commit 466d3bc into amzn:develop Feb 20, 2019
@meissnereric meissnereric deleted the inference_doc branch February 20, 2019 11:16
@zhenwendai zhenwendai added this to the MXFusion v0.3.0 milestone Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants