Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for organizeImports command #241

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Conversation

ananthakumaran
Copy link
Owner

this command is only available on Typescript master branch

@josteink
Copy link
Collaborator

josteink commented Mar 1, 2018

Woo! Another feature!

Based on what I read here, it seems all this should do is sort the imports. I've tested that, and it seems to work for me.

Besides that, the code changes looks good to me. I especially like the new way of handling compatibility.

I'd preferred it to be split over 2 commits (refactor, add feature), but now that it's already done, I'm not sure it's worth the trouble splitting up.

I'm OK with this getting merged as is. Good job :)

@ananthakumaran
Copy link
Owner Author

Thanks, I kind of got lazy and did the refactor in the middle.

@ananthakumaran ananthakumaran merged commit 30cef27 into master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants