This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
Clean #5
Merged
Clean #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought about this feature, but I avoided it because I thought it might affect performance, but it seems to be important and if we make a simple format for the config file we can reduce the impact on performance |
0x61nas
suggested changes
Jun 10, 2022
| ## TODO | ||
|
|
||
| - [ ] Add Tests | ||
| - [ ] Add Formatter |
There was a problem hiding this comment.
I mean code formatter like prettier
It would be nice if you added a pre-commit hook that takes care of formatting and testing before commiting/pushing to the master branch.
…() and make it return Object[] instead of String
|
Kudos, SonarCloud Quality Gate passed!
|
0x61nas
approved these changes
Jun 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the code is much cleaner now and easier to read
please add a config file parser that parse config file which is defined by the user, the user can specify custom icons, colors and settings.
I forgot to add that in the TODO section.