Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 639 prints in cdxj #3

Conversation

machawk1
Copy link

@machawk1 machawk1 commented Jul 1, 2020

Just rebases on oduwsdl/ipwb to hopefully ease the eventual acceptance of oduwsdl#640.

ibnesayeed and others added 30 commits April 28, 2020 19:41
Temporarily install ipfshttpclient from master branch
With oduwsdl#638's temporary fix to account for the delta in the ipfshttpclient master and latest release, we can start testing on the latest go-ipfs binary. Closes oduwsdl#642
Update Travis for testing with go-ipfs v0.5.0
Re: oduwsdl#647
Closes oduwsdl#646

Co-authored-by: Sawood Alam <ibnesayeed@gmail.com>
Update TravisCI to use go-ipfs 0.5.1
Add GH Workflow for cross-platform tests
machawk1 and others added 25 commits June 25, 2020 12:19
Streamline release and publish process
Remove unnecessary condition from Docker image build
Migrate IPFS store automatically when needed
Update dependency to the official IPFS client
Rebase on oduwsdl master
@machawk1
Copy link
Author

machawk1 commented Jul 1, 2020

Ping @anatoly-scherbakov

@anatoly-scherbakov
Copy link
Owner

Hello @machawk1 ! I recall that I wanted to remove a "print" statement which was obscuring the output files, but I think I started to add too many changes in that commit which were not backwards compatible and did not allow to merge the change. Let me see if I can come back to this before end of this week (on the weekend probably) and come up with something.

@machawk1
Copy link
Author

machawk1 commented Jul 1, 2020

Hi, @anatoly-scherbakov, I agree. I would like to see your work merged but the fact that there are multiple changes, I believe, is the reason for the hold-up on merging. Perhaps a PR decoupling the version update check, which was one source of print then a separate one changing the prints to use the logger would help to get your work merged in. I am looking forward to what you come up with.

@anatoly-scherbakov anatoly-scherbakov merged commit 2088f74 into anatoly-scherbakov:issue-639-prints-in-cdxj Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants