bson_simple for simple namedtuples (#25)

ancapdev · Oct 5, 2022 · 69e129a · 69e129a · ancapdev · Oct 5, 2022
1 parent ed7432c
commit 69e129a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "LightBSON"
 uuid = "a4a7f996-b3a6-4de6-b9db-2fa5f350df41"
 authors = ["Christian Rorvik <christian.rorvik@gmail.com>"]
-version = "0.2.14"
+version = "0.2.15"
 
 [deps]
 DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"

diff --git a/src/LightBSON.jl b/src/LightBSON.jl
@@ -65,6 +65,7 @@ bson_schema_version(::Type{T}) where T = nothing
 bson_schema_version_field(::Type{T}) where T = "_v"
 
 bson_simple(::Type{T}) where T = StructTypes.StructType(T) == StructTypes.NoStructType()
+bson_simple(::Type{<:NamedTuple}) = true
 
 include("object_id.jl")
 include("types.jl")

diff --git a/src/writer.jl b/src/writer.jl
@@ -199,16 +199,6 @@ function Base.setindex!(writer::BSONWriter, fields::Tuple{Vararg{Pair{String, T}
     nothing
 end
 
-@generated function Base.setindex!(writer::BSONWriter, fields::T) where T <: NamedTuple
-    e = Expr(:block)
-    for fn in fieldnames(T)
-        fns = "$fn"
-        push!(e.args, :(writer[$fns] = fields.$fn))
-    end
-    push!(e.args, nothing)
-    e
-end
-
 @inline @generated function bson_write_simple(writer::BSONWriter, value::T) where T
     fieldcount(T) == 0 && return nothing
     totalsize = sum(wire_size_, fieldtypes(T)) + sum(sizeof, fieldnames(T)) + fieldcount(T) * 2