feat: prototype of grype explain #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmurphyscode
force-pushed
the
grype-cve-explain
branch
3 times, most recently
from
0306a30 to
3ecd88f
Compare
Signed-off-by: Will Murphy <will.murphy@anchore.com> WIP Signed-off-by: Will Murphy <will.murphy@anchore.com> WIP: working explain command Signed-off-by: Will Murphy <will.murphy@anchore.com> WIP track explanation model Signed-off-by: Will Murphy <will.murphy@anchore.com> Working template for exact-indirect-matches Signed-off-by: Will Murphy <will.murphy@anchore.com> Format CPE matches; add datasource URL Signed-off-by: Will Murphy <will.murphy@anchore.com> some cleanup Signed-off-by: Will Murphy <will.murphy@anchore.com> WIP: a few more details Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Previously they were grouped by artifact ID, which was noisy because it made a lot of similar, small-ish groups. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Previous code assumed primary was a property of a match, but really it's a property of a vulnerability. Rearrange the code to choose a pimary vulnerability. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
willmurphyscode
force-pushed
the
grype-cve-explain
branch
from
797f9c0 to
03dc5db
Compare
spiffcs
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Comments added about cleaning up the comments and potential reminders that have been sitting around - are there any integration/cli tests we want to add for this one. Maybe just a smoke test to give the 👍 it's executing and producing the correct results?
The rest of explain looks technically correct - no hard to catch bugs or otherwise hard to read code.
@willmurphyscode I can do another pass this PM so we can get this prototype out for users to start kicking the tires on
wagoodman
approved these changes
Sep 11, 2023
Signed-off-by: Will Murphy <will.murphy@anchore.com>
spiffcs
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1342.
Still WIP. Mostly using #1342 to comment on what the desired output should look like, then will clean up this branch and get ready to merge.This is an initial prototype of
grype explain. The goal is to get something in front of users so that they can try out the experience and we can start getting feedback. This is NOT a final version of the output, or a final factoring of the code that renders the output.Note: this is invoked on grype JSON output, like
grype -q alpine:3.7 -o json | go run cmd/grype/main.go explain --id CVE-2022-48174.