Skip to content

Commit

Permalink
Add another critical extension bypass.
Browse files Browse the repository at this point in the history
Signed-off-by: Timotej Ecimovic <t1@digitalgeyser.com>
  • Loading branch information
tecimovic committed Oct 13, 2024
1 parent 4cd2cbc commit e863ee3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ CHANGELOG.md
.tmp/
coverage.txt
bin/
cmd/quill/quill

# Binaries for programs and plugins
*.exe
Expand All @@ -40,4 +41,4 @@ bin/
# macOS Finder metadata
.DS_STORE

*.profile
*.profile
6 changes: 4 additions & 2 deletions quill/pki/certchain/verify.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,13 @@ func VerifyForCodeSigning(certs []*x509.Certificate, failWithoutFullChain bool)
},
}

// ignore "devid_execute" critical extension
// ignore "devid_execute" and "devid_kernel" critical extensions
temp := leaf.UnhandledCriticalExtensions[:0]
for _, ex := range leaf.UnhandledCriticalExtensions {
switch ex.String() {
case "1.2.840.113635.100.6.1.13":
case "1.2.840.113635.100.6.1.13": // devid_execute
continue
case "1.2.840.113635.100.6.1.18": // devid_kernel
continue
default:
temp = append(temp, ex)
Expand Down

0 comments on commit e863ee3

Please sign in to comment.