fix: move defer after error to protect panic case (#1670)

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
anchore · Mar 15, 2023 · 61362c0 · 61362c0
1 parent e314006
commit 61362c0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/syft/source/source.go b/syft/source/source.go
@@ -385,11 +385,11 @@ func (s *Source) SetID() {
 	case FileScheme:
 		// attempt to use the digest of the contents of the file as the ID
 		file, err := os.Open(s.Metadata.Path)
-		defer file.Close()
 		if err != nil {
 			d = digest.FromString(s.Metadata.Path).String()
 			break
 		}
+		defer file.Close()
 		di, err := digest.FromReader(file)
 		if err != nil {
 			d = digest.FromString(s.Metadata.Path).String()