Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pnpm support #1535

Closed
bretik opened this issue Feb 3, 2023 · 3 comments · Fixed by #1752
Closed

Improve pnpm support #1535

bretik opened this issue Feb 3, 2023 · 3 comments · Fixed by #1752
Labels
enhancement New feature or request good-first-issue Good for newcomers

Comments

@bretik
Copy link

bretik commented Feb 3, 2023

What would you like to be added:

  1. Transitive dependencies - in the first example, react package is referenced and it has two transitive dependencies, that are not in the output (loose-envify => js-tokens)
  2. Workspaces - Please add support for reading dependencies from pnpm-lock.yaml created in project that is using workspaces. Currently no deps are discovered for this file.

Why is this needed:
To improve support of pnpm.

Additional context:
@bretik bretik added the enhancement New feature or request label Feb 3, 2023
@tgerla tgerla added the good-first-issue Good for newcomers label Mar 9, 2023
@tgerla
Copy link
Contributor

tgerla commented Mar 9, 2023

Hi @bretik, thanks for the suggestions! We will add them to the backlog and if you ever feel like working on this yourself, let us know and we can point you in the right direction.

@shanedell
Copy link
Contributor

shanedell commented Apr 19, 2023 •
edited
Loading

I would like to work on this if its available.

Would it possibly be easier to parse the packages: section? Based on the examples given it seems this would hold the list of dependencies and their transitive dependencies.

@bretik
Copy link
Author

bretik commented Apr 20, 2023

Hi, yes - it seems that parsing packages is the correct way and will solve both cases.

shanedell added a commit to shanedell/syft that referenced this issue Apr 20, 2023
@shanedell
Improve pnpm support.
02578af 
- Parse packages section from pnpm-lock.yaml to get transitive dependencies.
- Should add support for getting dependencies from pnpm-lock.yaml files that use workspaces.
  - This is due to the fact all dependencies should get listed under the packages section.

Closes anchore#1535

Signed-off-by: Shane Dell <shanedell100@gmail.com>
@shanedell shanedell mentioned this issue Apr 20, 2023
Merged
shanedell added a commit to shanedell/syft that referenced this issue Apr 20, 2023
@shanedell
Improve pnpm support
99353cb 
- Parse packages section from pnpm-lock.yaml to get transitive dependencies.
- Should add support for getting dependencies from pnpm-lock.yaml files that use workspaces.
  - This is due to the fact all dependencies should get listed under the packages section.

Closes anchore#1535

Signed-off-by: Shane Dell <shanedell100@gmail.com>
shanedell added a commit to shanedell/syft that referenced this issue Apr 21, 2023
@shanedell
Improve pnpm support
60cd03f 
- Parse packages section from pnpm-lock.yaml to get transitive dependencies.
- Should add support for getting dependencies from pnpm-lock.yaml files that use workspaces.
  - This is due to the fact all dependencies should get listed under the packages section.

Closes anchore#1535

Signed-off-by: Shane Dell <shanedell100@gmail.com>
This was referenced May 8, 2023
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced May 22, 2023
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-first-issue Good for newcomers
Projects
OSS
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve pnpm support shanedell/syft
3 participants
@tgerla @bretik @shanedell