Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install script returns exit code 0 even if install fails #1566

Closed
blowfishpro opened this issue Feb 13, 2023 · 0 comments · Fixed by #1915
Closed

Install script returns exit code 0 even if install fails #1566

blowfishpro opened this issue Feb 13, 2023 · 0 comments · Fixed by #1915
Labels
bug Something isn't working good-first-issue Good for newcomers

Comments

@blowfishpro
Copy link

Please provide a set of steps on how to reproduce the issue

  • Attempt to install syft via the recommended method (curl piped to sh)
  • Have some issue that would cause the installation to fail (e.g. no permissions on the target directory)

What happened:

  • The installation script exits with code 0 (verified this wasn't a pipe issue etc)

What you expected to happen:

  • The installation script exits with a nonzero code when it fails

Anything else we need to know?:

  • Since the install script does not set -e, perhaps this should store the exit code and then return it later?

Environment:

  • Output of syft version: n/a
  • OS (e.g: cat /etc/os-release or similar): Tested on Unbutu but it shouldn't really matter
@blowfishpro blowfishpro added the bug Something isn't working label Feb 13, 2023
@tgerla tgerla added the good-first-issue Good for newcomers label Feb 16, 2023
@lorsatti lorsatti mentioned this issue Jul 5, 2023
Merged
spiffcs added a commit that referenced this issue Jul 6, 2023
@lorsatti @spiffcs
fix(install): return with right error code (#1915)
376c428 
This resolves #1566.

Signed-off-by: Lorenzo Orsatti <49567430+lorsatti@users.noreply.github.com>
Co-authored-by: Christopher Phillips <cphillips918@gmail.com>
This was referenced Jul 12, 2023
Open
Closed
Merged
Closed
Open
Closed
Open
Closed
This was referenced Jul 28, 2023
Closed
Closed
Closed
GijsCalis pushed a commit to GijsCalis/syft that referenced this issue Feb 19, 2024
@lorsatti @spiffcs
fix(install): return with right error code (anchore#1915)
693a468 
This resolves anchore#1566.

Signed-off-by: Lorenzo Orsatti <49567430+lorsatti@users.noreply.github.com>
Co-authored-by: Christopher Phillips <cphillips918@gmail.com>
hacst added a commit to hacst/syft that referenced this issue Feb 22, 2024
@hacst
fix(install): actually return right error codes
fa0384f 
Previously exit was called with the stdout content of
the main function. This did not make sense and
resulted in the script not returning the expected
exit codes when main returned a non-zero code.

Strangely enough this broken code was introduced in
response to anchore#1566 but I do not see how it ever worked
unless the script used to echo its intended exit code.
hacst added a commit to hacst/syft that referenced this issue Feb 22, 2024
@hacst
fix(install): actually return right error codes
6082252 
Previously exit was called with the stdout content of
the main function. This did not make sense and
resulted in the script not returning the expected
exit codes when main returned a non-zero code.

Strangely enough this broken code was introduced in
response to anchore#1566 but I do not see how it ever worked
unless the script used to echo its intended exit code.

Signed-off-by: Stefan Hacker <mail@hacst.net>
hacst added a commit to hacst/syft that referenced this issue Feb 22, 2024
@hacst
fix(install): actually return right error codes
63d7744 
Previously exit was called with the stdout content of
the main function. This did not make sense and
resulted in the script not returning the expected
exit codes when main returned a non-zero code.

Strangely enough this broken code was introduced in
response to anchore#1566 but I do not see how it ever worked
unless the script used to echo its intended exit code.

Signed-off-by: Stefan Hacker <mail@hacst.net>
@hacst hacst mentioned this issue Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good-first-issue Good for newcomers
Projects
OSS
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(install): return right error code lorsatti/syft
2 participants
@tgerla @blowfishpro