Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: python CPE generation for alpine #1564

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

westonsteimel
Copy link
Contributor

Accurate CPE generation is important for getting accurate matches for alpine packages since it uses the NVD data to match and the alpine fix feed to deselect matches accordingly. This ensures we generate expected CPE's for python3 and python.

Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
@westonsteimel westonsteimel requested a review from a team February 10, 2023 17:58
@westonsteimel westonsteimel enabled auto-merge (squash) February 10, 2023 18:02
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux
goarch: amd64
pkg: github.com/anchore/syft/test/integration
cpu: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
                                                          │ ./.tmp/benchmark-b37c22a.txt │
                                                          │            sec/op            │
ImagePackageCatalogers/alpmdb-cataloger-2                                   16.31m ±  3%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             1.234m ± 20%
ImagePackageCatalogers/python-package-cataloger-2                           2.781m ±  9%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   905.2µ ±  3%
ImagePackageCatalogers/javascript-package-cataloger-2                       501.5µ ±  2%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   705.7µ ±  3%
ImagePackageCatalogers/rpm-db-cataloger-2                                   642.8µ ±  2%
ImagePackageCatalogers/java-cataloger-2                                     13.23m ±  4%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     11.05µ ±  4%
ImagePackageCatalogers/apkdb-cataloger-2                                    659.9µ ±  3%
ImagePackageCatalogers/go-module-binary-cataloger-2                         23.10µ ±  3%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              1.257m ±  2%
ImagePackageCatalogers/portage-cataloger-2                                  447.5µ ±  4%
ImagePackageCatalogers/sbom-cataloger-2                                     135.6µ ±  5%
ImagePackageCatalogers/binary-cataloger-2                                   183.2µ ±  2%
geomean                                                                     589.3µ

                                                          │ ./.tmp/benchmark-b37c22a.txt │
                                                          │             B/op             │
ImagePackageCatalogers/alpmdb-cataloger-2                                   5.061Mi ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             141.7Ki ± 0%
ImagePackageCatalogers/python-package-cataloger-2                           766.1Ki ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   155.9Ki ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                       95.45Ki ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   144.6Ki ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                   170.2Ki ± 0%
ImagePackageCatalogers/java-cataloger-2                                     2.721Mi ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     1.523Ki ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                    122.1Ki ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                         3.102Ki ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              314.7Ki ± 0%
ImagePackageCatalogers/portage-cataloger-2                                  75.38Ki ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                     13.02Ki ± 0%
ImagePackageCatalogers/binary-cataloger-2                                   20.51Ki ± 0%
geomean                                                                     105.1Ki

                                                          │ ./.tmp/benchmark-b37c22a.txt │
                                                          │          allocs/op           │
ImagePackageCatalogers/alpmdb-cataloger-2                                    86.71k ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.159k ± 0%
ImagePackageCatalogers/python-package-cataloger-2                            10.35k ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                    3.457k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                        1.252k ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                    2.646k ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                    3.759k ± 0%
ImagePackageCatalogers/java-cataloger-2                                      38.26k ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                       40.00 ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                     3.234k ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                           101.0 ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                               5.011k ± 0%
ImagePackageCatalogers/portage-cataloger-2                                   1.487k ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                       392.0 ± 0%
ImagePackageCatalogers/binary-cataloger-2                                     609.0 ± 0%
geomean                                                                      2.112k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants