Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue when matching format versions #1585

Merged

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Feb 17, 2023

While working on PR #1583 I noticed there was an edge-case matching minor versions, for example if Syft JSON format has version 7.0.0, requesting json@7.0 would not match.

Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow force-pushed the fix/format-sub-version-matching branch from 77c6689 to 6b30c83 Compare February 17, 2023 18:39
@spiffcs spiffcs merged commit 8f6a317 into anchore:main Feb 22, 2023
@wagoodman wagoodman added the bug Something isn't working label Feb 22, 2023
noqcks pushed a commit to noqcks/syft that referenced this pull request Feb 23, 2023
Signed-off-by: Keith Zantow <kzantow@gmail.com>
noqcks added a commit to noqcks/syft that referenced this pull request Feb 23, 2023
Signed-off-by: Benji Visser <benji@093b.org>

chore: update SPDX license list (anchore#1599)

Update SPDX license list to 3.20 (anchore#1600)

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>

Update Stereoscope to 529924d6d5aa6c708cceffc651883b6e1e27f5df (anchore#1602)

Signed-off-by: GitHub <noreply@github.com>

feat: add perl binary classifier (anchore#1592)

Signed-off-by: Benji Visser <benji@093b.org>

chore: update syft bootstrap tools to latest versions. (anchore#1593)

fix: issue when matching format versions (anchore#1585)

Signed-off-by: Keith Zantow <kzantow@gmail.com>

fix: merging of binary packages (anchore#1583)

chore: fix cataloger_test (anchore#1603)

Signed-off-by: Keith Zantow <kzantow@gmail.com>

Update Stereoscope to fab1c9638abc2c21cd53dca1f205f37d71148ee0 (anchore#1604)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: wagoodman <wagoodman@users.noreply.github.com>

Revert "add workaround for macos github actions cache issue (anchore#1584)" (anchore#1605)

This reverts commit 0076b19.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

remove schema 6.2.1

Signed-off-by: Benji Visser <benji@093b.org>
@kzantow kzantow deleted the fix/format-sub-version-matching branch November 29, 2023 18:24
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants