Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve CPE generation for curl APK #1608

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix: improve CPE generation for curl APK #1608

merged 1 commit into from
Feb 23, 2023

Conversation

westonsteimel
Copy link
Contributor

@westonsteimel westonsteimel commented Feb 23, 2023 •
edited
Loading

The correct CPE for curl is cpe:2.3:a:haxx:curl:*:*:*:*:*:*:*:*

@westonsteimel
fix: improve CPE generation for curl APK
2ba286e 
Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
goos: linux
goarch: amd64
pkg: github.com/anchore/syft/test/integration
cpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
                                                          │ ./.tmp/benchmark-1301c94.txt │
                                                          │            sec/op            │
ImagePackageCatalogers/alpmdb-cataloger-2                                   11.88m ±  2%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             857.7µ ± 16%
ImagePackageCatalogers/python-package-cataloger-2                           3.024m ±  1%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   658.0µ ±  1%
ImagePackageCatalogers/javascript-package-cataloger-2                       355.9µ ±  2%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   476.6µ ±  2%
ImagePackageCatalogers/rpm-db-cataloger-2                                   446.3µ ±  3%
ImagePackageCatalogers/java-cataloger-2                                     10.92m ±  1%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     8.009µ ±  2%
ImagePackageCatalogers/apkdb-cataloger-2                                    467.1µ ±  1%
ImagePackageCatalogers/go-module-binary-cataloger-2                         18.22µ ±  1%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              967.6µ ±  1%
ImagePackageCatalogers/portage-cataloger-2                                  288.1µ ±  2%
ImagePackageCatalogers/sbom-cataloger-2                                     104.7µ ±  1%
ImagePackageCatalogers/binary-cataloger-2                                   140.3µ ±  1%
geomean                                                                     441.3µ

                                                          │ ./.tmp/benchmark-1301c94.txt │
                                                          │             B/op             │
ImagePackageCatalogers/alpmdb-cataloger-2                                   5.060Mi ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             141.9Ki ± 0%
ImagePackageCatalogers/python-package-cataloger-2                           947.0Ki ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   155.8Ki ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                       95.93Ki ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   144.5Ki ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                   170.7Ki ± 0%
ImagePackageCatalogers/java-cataloger-2                                     2.724Mi ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     1.523Ki ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                    123.0Ki ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                         3.102Ki ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              314.0Ki ± 0%
ImagePackageCatalogers/portage-cataloger-2                                  75.50Ki ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                     13.06Ki ± 0%
ImagePackageCatalogers/binary-cataloger-2                                   20.83Ki ± 0%
geomean                                                                     106.8Ki

                                                          │ ./.tmp/benchmark-1301c94.txt │
                                                          │          allocs/op           │
ImagePackageCatalogers/alpmdb-cataloger-2                                    86.71k ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.159k ± 0%
ImagePackageCatalogers/python-package-cataloger-2                            15.48k ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                    3.457k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                        1.253k ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                    2.646k ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                    3.759k ± 0%
ImagePackageCatalogers/java-cataloger-2                                      38.26k ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                       40.00 ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                     3.252k ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                           101.0 ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                               5.010k ± 0%
ImagePackageCatalogers/portage-cataloger-2                                   1.487k ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                       392.0 ± 0%
ImagePackageCatalogers/binary-cataloger-2                                     627.0 ± 0%
geomean                                                                      2.175k

@westonsteimel westonsteimel requested a review from a team February 23, 2023 14:31
@westonsteimel westonsteimel merged commit 1150772 into main Feb 23, 2023
@westonsteimel westonsteimel deleted the apk-curl-cpe-improvements branch February 23, 2023 17:32
@kzantow kzantow added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Mar 2, 2023
This was referenced Mar 2, 2023
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Open
Open
Open
Open
Open
This was referenced Mar 10, 2023
Open
Closed
Closed
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@westonsteimel
fix: improve CPE generation for curl APK (anchore#1608)
9c82f5c 
Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@westonsteimel @kzantow