Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format make target #1733

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Add format make target #1733

merged 1 commit into from
Apr 12, 2023

Conversation

wagoodman
Copy link
Contributor

Splits the format-related tasks in the lint-fix target into a new format target (which lint-fix depends on)

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman added the changelog-ignore Don't include this issue in the release changelog label Apr 12, 2023
@wagoodman wagoodman requested a review from a team April 12, 2023 17:52
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz%0A                                                          │ ./.tmp/benchmark-596c96c.txt │%0A                                                          │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   11.97m ± 26%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             948.0µ ±  5%25%0AImagePackageCatalogers/python-package-cataloger-2                           3.184m ±  2%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   748.7µ ±  9%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       426.4µ ±  9%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   595.6µ ±  2%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   561.5µ ±  3%25%0AImagePackageCatalogers/java-cataloger-2                                     11.61m ±  4%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     8.819µ ±  9%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    603.2µ ±  3%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         20.25µ ±  4%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              1.103m ±  5%25%0AImagePackageCatalogers/portage-cataloger-2                                  402.3µ ±  6%25%0AImagePackageCatalogers/nix-store-cataloger-2                                249.4µ ±  4%25%0AImagePackageCatalogers/sbom-cataloger-2                                     116.4µ ±  3%25%0AImagePackageCatalogers/binary-cataloger-2                                   202.7µ ±  4%25%0Ageomean                                                                     494.0µ%0A%0A                                                          │ ./.tmp/benchmark-596c96c.txt │%0A                                                          │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   5.062Mi ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             123.8Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                           947.4Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   155.8Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       90.59Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   144.6Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   170.1Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                     2.755Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     1.555Ki ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    129.2Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         3.133Ki ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              314.2Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                  77.22Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                36.07Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                     13.55Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                   29.88Ki ± 0%25%0Ageomean                                                                     101.8Ki%0A%0A                                                          │ ./.tmp/benchmark-596c96c.txt │%0A                                                          │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                    86.71k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.049k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                            15.48k ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                    3.458k ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                        1.205k ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                    2.646k ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                    3.759k ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                      38.97k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                       40.00 ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                     3.438k ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                           101.0 ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                               5.010k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                   1.539k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                  671.0 ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                       392.0 ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                     872.0 ± 0%25%0Ageomean                                                                      2.065k

@wagoodman wagoodman enabled auto-merge (squash) April 12, 2023 18:22
@wagoodman wagoodman merged commit 0571548 into main Apr 12, 2023
@wagoodman wagoodman deleted the make-format branch April 12, 2023 18:36
spiffcs added a commit that referenced this pull request Apr 17, 2023
* main: (35 commits)
  Fix kernel cataloger test fixtures (#1742)
  feat: Support scanning license files in golang packages over the network (#1630)
  Add package-to-file location evidence relationships (#1698)
  Add Linux Kernel cataloger (#1694)
  Add annotations for evidence on package locations (#1723)
  add format make target (#1733)
  Update tests to not fail on Mac M1's. (#1730)
  chore(deps): update bootstrap tools to latest versions (#1728)
  Add support for nar files. (#1727)
  add highlevel details about catalogers (#1726)
  chore(deps): bump golang.org/x/net from 0.8.0 to 0.9.0 (#1722)
  chore(deps): update stereoscope to e95d60a265e384df29b7a139f5c5402d6ad72e06 (#1721)
  feat: gradle lockfile support (#1719)
  chore(deps): bump github.com/docker/docker (#1715)
  chore(deps): bump golang.org/x/mod from 0.9.0 to 0.10.0 (#1713)
  chore(deps): bump golang.org/x/term from 0.6.0 to 0.7.0 (#1714)
  chore(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 (#1716)
  chore(deps): bump peter-evans/create-pull-request from 4 to 5 (#1712)
  chore: update tools-golang to v0.5.0 (#1717)
  Add Nix cataloger (#1696)
  ...

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-ignore Don't include this issue in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants