Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sbom.PackageCatalog to sbom.Packages #1773

Merged
merged 1 commit into from
May 1, 2023
Merged

Rename sbom.PackageCatalog to sbom.Packages #1773

merged 1 commit into from
May 1, 2023

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented May 1, 2023 •
edited
Loading

Follow up to #1764 by renaming the sbom.PackageCatalog to sbom.Packages (related to the #558 work).

@wagoodman
rename sbom.PackageCatalog to sbom.Packages
f849438 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman added the breaking-change Change is not backwards compatible label May 1, 2023
@wagoodman wagoodman requested a review from a team May 1, 2023 13:27
@wagoodman wagoodman self-assigned this May 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz%0A                                                          │ ./.tmp/benchmark-c4506e8.txt │%0A                                                          │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   11.57m ±  2%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             834.4µ ±  1%25%0AImagePackageCatalogers/python-package-cataloger-2                           3.031m ±  0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   717.7µ ±  1%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       362.3µ ±  3%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   542.5µ ±  2%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   458.6µ ±  1%25%0AImagePackageCatalogers/java-cataloger-2                                     12.80m ±  1%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     91.41µ ± 15%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    541.4µ ±  1%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         91.25µ ±  0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              1.179m ±  1%25%0AImagePackageCatalogers/portage-cataloger-2                                  326.0µ ±  1%25%0AImagePackageCatalogers/nix-store-cataloger-2                                244.0µ ±  2%25%0AImagePackageCatalogers/sbom-cataloger-2                                     114.8µ ±  0%25%0AImagePackageCatalogers/binary-cataloger-2                                   208.4µ ±  0%25%0AImagePackageCatalogers/linux-kernel-cataloger-2                             46.22m ± 16%25%0Ageomean                                                                     768.4µ%0A%0A                                                          │ ./.tmp/benchmark-c4506e8.txt │%0A                                                          │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   5.070Mi ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             140.3Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                           984.8Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   179.5Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       99.07Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   169.7Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   178.8Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                     2.785Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     8.750Ki ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    145.3Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         10.06Ki ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              409.2Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                  85.92Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                48.90Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                     14.21Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                   32.00Ki ± 0%25%0AImagePackageCatalogers/linux-kernel-cataloger-2                             62.65Mi ± 0%25%0Ageomean                                                                     192.9Ki%0A%0A                                                          │ ./.tmp/benchmark-c4506e8.txt │%0A                                                          │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                    86.83k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.280k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                            15.95k ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                    3.796k ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                        1.322k ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                    2.989k ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                    3.878k ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                      39.47k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                       228.0 ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                     3.666k ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                           281.0 ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                               6.325k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                   1.660k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                  884.0 ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                       394.0 ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                     896.0 ± 0%25%0AImagePackageCatalogers/linux-kernel-cataloger-2                              2.797k ± 0%25%0Ageomean                                                                      2.649k

@wagoodman wagoodman merged commit 5f3d4d2 into main May 1, 2023
@wagoodman wagoodman deleted the rename-sbom-pacakge-catalog branch May 1, 2023 14:19
spiffcs added a commit that referenced this pull request May 4, 2023
@spiffcs
Merge branch 'main' into 1577-license-revamp
28a41b7 
* main:
  chore(docs): Update lists of catalogers (#1780)
  chore: add more detail on SPDX file IDs (#1769)
  Search /usr/share for rpmdb to fix scan on ostree-managed images (#1756)
  chore(deps): bump github.com/docker/docker (#1767)
  rename sbom.PackageCatalog to sbom.Packages (#1773)
  chore(deps): bump modernc.org/sqlite from 1.22.0 to 1.22.1 (#1768)

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
rename sbom.PackageCatalog to sbom.Packages (anchore#1773)
611e824 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees

@wagoodman wagoodman

Labels
breaking-change Change is not backwards compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @kzantow