Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jotframe UI #1932

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Remove jotframe UI #1932

merged 1 commit into from
Jul 13, 2023

Conversation

wagoodman
Copy link
Contributor

Now that syft has moved to bubbletea (in #1888) and grype no longer needs the jotframe handler (in anchore/grype#1385) we can remove the jotframe UI and dependency entirely 🎉

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz%0A                                                          │ ./.tmp/benchmark-002d1b5.txt │%0A                                                          │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   15.26m ±  3%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    980.2µ ±  6%25%0AImagePackageCatalogers/binary-cataloger-2                                   260.8µ ±  5%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   846.9µ ±  6%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              1.731m ±  9%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         136.2µ ±  2%25%0AImagePackageCatalogers/java-cataloger-2                                     15.55m ±  1%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     131.0µ ±  3%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       574.6µ ±  7%25%0AImagePackageCatalogers/nix-store-cataloger-2                                404.7µ ±  5%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   1.108m ±  5%25%0AImagePackageCatalogers/portage-cataloger-2                                  678.1µ ±  6%25%0AImagePackageCatalogers/python-package-cataloger-2                           4.313m ±  2%25%0AImagePackageCatalogers/r-package-cataloger-2                                325.5µ ± 17%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   818.9µ ± 11%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             1.356m ±  5%25%0AImagePackageCatalogers/sbom-cataloger-2                                     161.8µ ±  6%25%0Ageomean                                                                     855.1µ%0A%0A                                                          │ ./.tmp/benchmark-002d1b5.txt │%0A                                                          │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   5.119Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    205.2Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                   30.18Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   168.7Ki ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              404.6Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         9.906Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                     2.826Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     8.595Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       100.9Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                49.14Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   186.6Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                  120.0Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                           1.003Mi ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                53.30Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   180.9Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             144.0Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                     14.20Ki ± 0%25%0Ageomean                                                                     132.7Ki%0A%0A                                                          │ ./.tmp/benchmark-002d1b5.txt │%0A                                                          │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                    87.74k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                     4.182k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                     830.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                    3.002k ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                               6.338k ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                           281.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                      39.88k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                       228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                        1.404k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                  895.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                    4.079k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                   2.268k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                            16.44k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                  929.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                    3.989k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.447k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                       394.0 ± 0%25%0Ageomean                                                                      2.582k

@wagoodman wagoodman marked this pull request as ready for review July 12, 2023 18:27
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change is not backwards compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants