Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: in some cases, try to use pom info to guess name and version to top level jar #2080

Merged
merged 7 commits into from
Aug 31, 2023
Merged

fix: in some cases, try to use pom info to guess name and version to top level jar #2080

merged 7 commits into from
Aug 31, 2023

Commits on Aug 30, 2023

  1. initial failing test 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    f347fb0 View commit details
    Browse the repository at this point in the history

  2. passes initial test 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    44df88f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. only trust lonely pom.xml if filename is prefix of artifact id 

    All tests pass, but hacky.

Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    714d208 View commit details
    Browse the repository at this point in the history

  2. extract name and version guessing 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    09bdd84 View commit details
    Browse the repository at this point in the history

  3. linter 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    37337b5 View commit details
    Browse the repository at this point in the history

  4. Account for having mismatched count of pom.xml and pom.properties 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    1f37909 View commit details
    Browse the repository at this point in the history

  5. remove todo 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    878b5a4 View commit details
    Browse the repository at this point in the history