Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capture-snippet.sh can handle leading whitespaces now (#3249) #3250

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion syft/pkg/cataloger/binary/test-fixtures/capture-snippet.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ if ! command -v xxd &> /dev/null; then
exit 1
fi

# check if xargs is even installed
if ! command -v xargs &> /dev/null; then
echo "xargs not found. Please install xargs."
exit 1
fi

PATTERN=${SEARCH_FOR:-$VERSION}

Expand Down Expand Up @@ -116,7 +121,7 @@ while $CONTINUE_LOOP; do
fi

# search for the pattern in the binary file and capture the offset
OFFSET=$(echo "${SELECTED_RESULT}" | cut -d ' ' -f 1)
OFFSET=$(echo "${SELECTED_RESULT}" | xargs | cut -d ' ' -f 1)

if [ -z "$OFFSET" ]; then
echo "Pattern not found."
Expand Down
Loading