Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add binary classifiers for lighttp, proftpd, zstd, xz, gzip, jq, and sqlcipher #3252

Merged
merged 8 commits into from
Sep 19, 2024
Merged

feat: add binary classifiers for lighttp, proftpd, zstd, xz, gzip, jq, and sqlcipher #3252

merged 8 commits into from
Sep 19, 2024

Conversation

krysgor
Copy link
Contributor

@krysgor krysgor commented Sep 19, 2024

Adding binary classifiers for:

  • lighttpd
  • proftpd
  • zstd
  • xz utils
  • gzip
  • sqlcipher
  • jq

Krystian Gorny added 7 commits September 19, 2024 12:49
feat: detect lighttpd binaries
a4cfadc 
Signed-off-by: Krystian Gorny <krystian.gorny@wipotec.com>
feat: detect proftpd binaries
a9656d4 
Signed-off-by: Krystian Gorny <krystian.gorny@wipotec.com>
feat: detect zstd binaries
4a21e63 
Signed-off-by: Krystian Gorny <krystian.gorny@wipotec.com>
feat: detect xz utils binarie
5d61e1c 
Signed-off-by: Krystian Gorny <krystian.gorny@wipotec.com>
feat: detect gzip binaries
f5d6c4b 
Signed-off-by: Krystian Gorny <krystian.gorny@wipotec.com>
feat: detect sqlcipher binaries
2b1370b 
Signed-off-by: Krystian Gorny <krystian.gorny@wipotec.com>
feat: detect jq binaries
a059939 
Signed-off-by: Krystian Gorny <krystian.gorny@wipotec.com>
@krysgor krysgor changed the title Add multiple binary classifiers feat: add multiple binary classifiers Sep 19, 2024
@wagoodman wagoodman self-assigned this Sep 19, 2024
@wagoodman
add tests + snippets
e65c335 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman
Copy link
Contributor

Thanks for adding these bin patterns!

I pushed up tests for each new pattern... for reference, I captured snippets with:

cd syft/pkg/cataloger/binary/test-fixtures
make add-snippet
...

@wagoodman wagoodman changed the title feat: add multiple binary classifiers feat: add binary classifiers for lighttp, proftpd, zstd, xz, gzip, jq, and sqlcipher Sep 19, 2024
@wagoodman wagoodman added the enhancement New feature or request label Sep 19, 2024
@wagoodman wagoodman enabled auto-merge (squash) September 19, 2024 13:14
@wagoodman wagoodman merged commit 6a95a5f into anchore:main Sep 19, 2024
12 checks passed
@krysgor krysgor deleted the devel branch September 24, 2024 05:27
@BrewTestBot BrewTestBot mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees

@wagoodman wagoodman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krysgor @wagoodman