Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

fix: use 74-byte packets for IP Discovery #525

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

crivasr
Copy link
Contributor

@crivasr crivasr commented Mar 10, 2023

Description

The library is using the old IP Discovery protocol that has been deprecated since december 2019. That old protocol will continue to work until march 15th according to their anouncement in the discord developers server. I've changed the udp packet so it uses the new protocol documented here.

Breaking Change?

no

Checklist:

  • I have performed a self-review of my own code
  • Commented complex situations or referenced the discord documentation
  • Updated documentation
  • Added/Updated unit tests
  • Added/Updated benchmarks (if this is a performance critical component)

@andersfylling andersfylling changed the title Use 74-byte packets for IP Discovery fix: use 74-byte packets for IP Discovery Mar 10, 2023
Copy link
Owner

@andersfylling andersfylling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@andersfylling andersfylling merged commit 16ea98e into andersfylling:master Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants