Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDU: fix ExpressionChangedAfterItHasBeenCheckedError perfiles #1948

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

plammel
Copy link
Contributor

@plammel plammel commented Oct 8, 2020

Requerimiento

https://proyectos.andes.gob.ar/browse/GDU-26

Funcionalidad desarrollada

  1. fix ExpressionChangedAfterItHasBeenCheckedError perfiles

UserStory llegó a completarse

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

  • Si
  • No

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@plammel plammel requested review from a team as code owners October 8, 2020 18:01
@liquid36
Copy link
Contributor

liquid36 commented Oct 8, 2020

BUILD NUMBER: 2138
TEST START: 2020-10-08T18:12:17.100Z
TOTAL: 302
SUCCESS: 302
FAIL: 0
SKIPPED: 0

@liquid36 liquid36 added the test ok Los test estan ok label Oct 8, 2020
@@ -11,14 +11,15 @@ import { Auth } from '@andes/auth';
})

export class PerfilListComponent implements OnInit {
selectedId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se puede marcar como privada la variable


constructor(
public perfilesHttp: PerfilesHttp,
public plex: Plex,
private location: Location,
private router: Router,
private route: ActivatedRoute,
private auth: Auth
private auth: Auth,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aparece como modificada la línea pero solo se sumó una coma

@plammel plammel force-pushed the GDU-26 branch 2 times, most recently from 568315b to 48a5ff6 Compare October 9, 2020 13:02
@liquid36
Copy link
Contributor

liquid36 commented Oct 9, 2020

BUILD NUMBER: 2150
TEST START: 2020-10-09T15:10:31.435Z
TOTAL: 298
SUCCESS: 297
FAIL: 1
SKIPPED: 0

@liquid36 liquid36 added test fail and removed test ok Los test estan ok labels Oct 9, 2020
@liquid36
Copy link
Contributor

liquid36 commented Oct 9, 2020

BUILD NUMBER: 2152
TEST START: 2020-10-09T15:20:04.500Z
TOTAL: 19
SUCCESS: 19
FAIL: 0
SKIPPED: 0

@plammel plammel removed the test fail label Oct 13, 2020
@liquid36
Copy link
Contributor

USUARIO: plammel
BUILD NUMBER: 2174
TEST START: 2020-10-13T18:32:22.114Z
TOTAL: 309
SUCCESS: 303
FAIL: 6
SKIPPED: 0
⚠️⚠️⚠️⚠️
Hay archivos que no corrieron. Vuelva a intentar.

@liquid36 liquid36 added the test ok Los test estan ok label Oct 13, 2020
@liquid36
Copy link
Contributor

USUARIO: cceleste
BUILD NUMBER: 2270
CYPRESS RUN: 1445
TEST START: 2020-10-20T15:33:54.304Z
TOTAL: 323
SUCCESS: 323
FAIL: 0
SKIPPED: 0

@liquid36 liquid36 added test ok Los test estan ok and removed test ok Los test estan ok labels Oct 20, 2020
@kroce kroce merged commit 62c2b06 into master Oct 20, 2020
@kroce kroce deleted the GDU-26 branch October 20, 2020 15:43
liquid36 pushed a commit that referenced this pull request Oct 21, 2020
# [5.18.0](v5.17.0...v5.18.0) (2020-10-21)

### Bug Fixes

* **com:** limpiar sidebars al cambiar de derivacion ([#1953](#1953)) ([4f0da19](4f0da19))
* **com:** permitir al com cancelar sus derivaciones solicitadas ([#1955](#1955)) ([4f750f8](4f750f8))
* **GDU:** ExpressionChangedAfterItHasBeenCheckedError perfiles ([#1948](#1948)) ([62c2b06](62c2b06))
* **mapa-camas:** handle null al borrar sector ([#1974](#1974)) ([2390ee8](2390ee8))
* **rup:** solicitudes pierde el formato ([#1957](#1957)) ([f7129e3](f7129e3))

### Features

* **CITAS:** Habilita turnos de gestion en agendas del dia ([#1932](#1932)) ([4c6dc5a](4c6dc5a))
* **com:** marcar derivación seleccionada en plex-list ([#1975](#1975)) ([981daa8](981daa8))
* **com:** se suma fecha de creación/actualización a listado derivaciones ([#1959](#1959)) ([1af2284](1af2284))
* **mapa-camas:** agrega sector completo al abm de sala común ([#1963](#1963)) ([43f3e07](43f3e07))
* **mapa-camas:** columnas dinamicas ([#1949](#1949)) ([a0b9dce](a0b9dce))
* **mapa-camas:** componente de inconsistencias de camas ([#1746](#1746)) ([a2232e3](a2232e3))
* **mapa-camas:** control historial de cama al egresar ([#1880](#1880)) ([7b6c74e](7b6c74e))
* **mapa-camas:** deshacer internación  ([#1945](#1945)) ([67ea6a4](67ea6a4))

### Performance Improvements

* **huds:** quita sort inecesario ([#1952](#1952)) ([55ae989](55ae989))
* **top:** evita calcular estado todo el tiempo ([#1962](#1962)) ([3b358ae](3b358ae))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test ok Los test estan ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants