Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TURNOS-PRESTACIONES: Agregar virtual scroll y filtro ambito #2091

Merged
merged 2 commits into from
Dec 23, 2020
Merged

Conversation

martinebucarey
Copy link
Contributor

@martinebucarey martinebucarey commented Dec 17, 2020

Requerimiento

https://proyectos.andes.gob.ar/browse/MISC-115

Funcionalidad desarrollada

  1. Se agrega virtual scroll a la pantalla del buscador de turnos y prestaciones.
  2. Se agrega el filtro ambito dentro del conjunto de filtros"

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@martinebucarey martinebucarey requested review from a team as code owners December 17, 2020 17:10
@liquid36
Copy link
Contributor

USUARIO: martinebucarey
BUILD NUMBER: 2931
CYPRESS RUN: 2064
TEST START: 2020-12-17T17:24:30.521Z
TOTAL: 355
SUCCESS: 355
FAIL: 0
SKIPPED: 0

@liquid36 liquid36 added the test ok Los test estan ok label Dec 17, 2020

cdk-virtual-scroll-viewport {
height: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Para evitar el doble scroll:

Suggested change
height: 100%;
height: calc(100% - 180px);;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hecho

</plex-dropdown>
</plex-title>
<ng-container *ngIf="selectPrestaciones$ | async as selectPrestaciones">
<cdk-virtual-scroll-viewport [itemSize]="60">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es importante setear la altura correcta del item para que ande mejor el virtual scroll. Sino se aprecia que queda un vacío abajo.

Suggested change
<cdk-virtual-scroll-viewport [itemSize]="60">
<cdk-virtual-scroll-viewport [itemSize]="50">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hecho, es verdad no me habia dado cuenta

@liquid36 liquid36 added the changes requested Se solicitaron cambios label Dec 17, 2020
@liquid36 liquid36 added Aprobado and removed changes requested Se solicitaron cambios labels Dec 17, 2020
@liquid36 liquid36 merged commit 4f71dcc into master Dec 23, 2020
@liquid36 liquid36 deleted the MISC-115 branch December 23, 2020 15:03
liquid36 pushed a commit that referenced this pull request Dec 30, 2020
# [5.28.0](v5.27.0...v5.28.0) (2020-12-30)

### Features

* **mapa-camas:** controles de networking ([#2092](#2092)) ([1c97cb7](1c97cb7))
* **rup:** envios adjuntos ([#1848](#1848)) ([24cf9eb](24cf9eb))
* **RUP:** Agregar registro de vacuna covid ([#2094](#2094)) ([2328c5c](2328c5c))
* **top:** subir archivos a andesDrive ([#2089](#2089)) ([b43be2c](b43be2c))
* **turnos-prestaciones:** ambito y virtual scroll ([#2091](#2091)) ([4f71dcc](4f71dcc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aprobado test ok Los test estan ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants