MISC: componente semaforo priorizacion #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquid36
reviewed
Jun 25, 2021
| this.semaforoService.findByName('com').subscribe(res => this.opciones = res.options); | ||
| } | ||
|
|
||
| setPrioridad(prioridad) { |
There was a problem hiding this comment.
Esta mal modificar un input, debería trabajarlo con @output().
Ya que están armando todo una colección de semáforos configurable por módulos, pero la componente es rígida para el COM.
There was a problem hiding this comment.
Esta mal modificar un input, debería trabajarlo con @output().
Ya que están armando todo una colección de semáforos configurable por módulos, pero la componente es rígida para el COM.
updeteado!
plammel
force-pushed
the
MISC-171
branch
2 times, most recently
from
6598250
to
883ef43
Compare
andrrrl
suggested changes
Aug 9, 2021
src/app/modules/semaforo-priorizacion/components/semaforo-priorizacion.component.ts
Outdated
Show resolved
Hide resolved
liquid36
reviewed
Aug 10, 2021
| <div class="mt-1"> | ||
| <plex-label [tituloBold]="true" titulo="Prioridad"></plex-label> | ||
| <ng-container *ngFor="let p of opciones"> | ||
| <div [class]="p.label + ' box'" [ngStyle]="{ background: p.color }" [class.selected]="p.label === prioridad" (click)="select(p);" > |
There was a problem hiding this comment.
Suggested change
| <div [class]="p.label + ' box'" [ngStyle]="{ background: p.color }" [class.selected]="p.label === prioridad" (click)="select(p);" > | |
| <div class="box" [class]="p.label" [style.background]="p.color" [class.selected]="p.label === prioridad" (click)="select(p)" > |
liquid36
reviewed
Aug 10, 2021
| }) | ||
|
|
||
| export class SemaforoPriorizacionComponent implements OnInit { | ||
| @Output() onChangeEvent = new EventEmitter<any>(); |
There was a problem hiding this comment.
Suggested change
| @Output() onChangeEvent = new EventEmitter<any>(); | |
| @Output() change = new EventEmitter<any>(); |
liquid36
reviewed
Aug 10, 2021
| @Output() onChangeEvent = new EventEmitter<any>(); | ||
| @Input() name; | ||
| @Input() prioridad; | ||
| opciones; |
There was a problem hiding this comment.
Estaría bueno armar la interfaz y tipar en todas las compoenntes, así ya queda...
liquid36
reviewed
Aug 10, 2021
| opciones; | ||
|
|
||
| constructor( | ||
| private semaforoService: SemaforoService) { } |
There was a problem hiding this comment.
Suggested change
| private semaforoService: SemaforoService) { } | |
| private semaforoService: SemaforoService | |
| ) { } |
|
@liquid36 buenas observaciones! Listo todos los cambios! |
liquid36
approved these changes
Aug 10, 2021
plammel
force-pushed
the
MISC-171
branch
2 times, most recently
from
fc0c9d0
to
cde5b4c
Compare
martinebucarey
force-pushed
the
MISC-171
branch
from
cde5b4c
to
913b3ff
Compare
liquid36
pushed a commit
that referenced
this pull request
Aug 11, 2021
# [5.59.0](v5.58.0...v5.59.0) (2021-08-11) ### Bug Fixes * **ficha-epidemiologica:** fix duplicidad sidebars buscador ([#2396](#2396)) ([52100b2](52100b2)) ### Features * **EP:** refactor de historial de ficha ([#2385](#2385)) ([e86d733](e86d733)) * **huds:** clasificacion final ficha epidemiologica ([#2381](#2381)) ([36b932d](36b932d)) * **MISC:** componente semaforo priorizacion ([#2349](#2349)) ([2578922](2578922)) * **mpi:** permite letras en nro. de identificacion de extranjero ([#2386](#2386)) ([c8055e6](c8055e6)) * **per:** descargar listado de controles ([#2390](#2390)) ([8bbb5e5](8bbb5e5)) * **rup:** vista-prestacion boton editar ([#2137](#2137)) ([2a14035](2a14035))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/MISC-171
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Si Colección
semaforosemaforo com.txt
No
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion