Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIT: carga masiva de pacientes #2526

Merged
merged 1 commit into from
Feb 17, 2022
Merged

CIT: carga masiva de pacientes #2526

merged 1 commit into from
Feb 17, 2022

Conversation

plammel
Copy link
Contributor

@plammel plammel commented Nov 18, 2021

Requerimiento

https://proyectos.andes.gob.ar/browse/CIT-134
https://proyectos.andes.gob.ar/browse/CIT-153

Funcionalidad desarrollada

  1. Permite carga masiva de pacientes por consulta

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

Requiere actualizaciones en andesMicroservices

  • Si
  • No

Copy link
Contributor

@martinebucarey martinebucarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen

  • Cuando asignas los turnos, queda un disponible medio raro en los turnos
  • Por otro lado vamos a validar si con el permiso y que la agenda tenga pacientes simultáneos alcanza para que ya se pueda cargar masivamente. O que pueda llegar a haber agendas sin pacientes simultáneos que también se quieran cargar.

@@ -138,6 +139,7 @@ export class BotonesAgendaComponent implements OnInit {
const puedeBorrar = this.auth.getPermissions('turnos:agenda:puedeBorrar:').length > 0;
const puedeRevisar = this.auth.getPermissions('turnos:agenda:puedeRevision:').length > 0;
const puedeNota = this.auth.getPermissions('turnos:agenda:puedeNota:').length > 0;
const puedeCargar = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const puedeCargar = true;
const puedeCargar = this.auth.getPermissions('turnos:agenda:asignacionMasiva:').length > 0;

}));

let turnos = [];
this.agendasSeleccionadas[0].bloques.forEach(b => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Para analizar, si no hay lugar en la agenda no metería la mitad de los pacientes. Arrojaría un error.

Si la agenda es dinámica que pasa?

Copy link
Contributor

@liquid36 liquid36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queda pendiente sacar las queries desde los conceptos turneables.

@@ -190,6 +191,12 @@
</suspender-agenda>
</div>
</plex-box>
<plex-box *ngIf="enableQueries">
<app-bi-queries type="inscriptos-vacunacion">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta prohibido meter un plex-layout dentro de otro plex-layout. Acostumbrense a refactorizar componentes para que sean más reutilizables intramodulos.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La componente de bi-query debería quedar separada en dos. Una es la componente del routing y otra el motor que genera los argumentos dinámicamente.

@liquid36 liquid36 added the changes requested Se solicitaron cambios label Dec 7, 2021
@plammel plammel force-pushed the CIT-134b branch 2 times, most recently from f9bf0da to 4e467f6 Compare December 14, 2021 15:38
Copy link
Contributor

@martinebucarey martinebucarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No entiendo la separación de componentes bi, hay dos exactamente iguales y solo cambia la vista que uno llama al otro. Se hace por algo en especial así??

@@ -15,6 +15,8 @@ import { IZonaSanitaria } from 'src/app/interfaces/IZonaSanitaria';
styleUrls: ['./bi-queries.component.scss']
})
export class BiQueriesComponent implements OnInit {
@Input() type;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teniendo el array de queries, el type seguiría siendo necesario?? yo pensaba controlar lo que se hacia por el type, ahora por el array

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removido el type

@@ -1,9 +1,10 @@
<plex-layout>
<plex-layout-main>
<plex-title titulo="Ejecutar consultas">
<plex-button size="sm" type="success" (click)="descargar()" [disabled]="form.invalid">
<plex-button *ngIf="!type" size="sm" type="success" (click)="descargar()" [disabled]="form.invalid">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<plex-button *ngIf="!type" size="sm" type="success" (click)="descargar()" [disabled]="form.invalid">
<plex-button *ngIf="!queries.length" size="sm" type="success" (click)="descargar()" [disabled]="form.invalid">

@@ -67,9 +68,9 @@
</ng-container>
</form>
<div justify="center" class="h-75">
<plex-label titulo="Comience seleccionando una consulta" direction="column"
<plex-label *ngIf="!type" titulo="Comience seleccionando una consulta" direction="column"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<plex-label *ngIf="!type" titulo="Comience seleccionando una consulta" direction="column"
<plex-label *ngIf="!queries.length" titulo="Comience seleccionando una consulta" direction="column"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hecho!

@liquid36
Copy link
Contributor

USUARIO: plammel
BUILD NUMBER: 5704
CYPRESS RUN: 4628
TEST START: 2021-12-22T12:31:01.332Z
TOTAL: 404
SUCCESS: 401
FAIL: 2
SKIPPED: 1

@@ -190,6 +191,12 @@
</suspender-agenda>
</div>
</plex-box>
<plex-box *ngIf="enableQueries">
<app-bi-queries [queries]="queries">
<plex-button size="sm" type="danger" (click)="cerrarCargarPacientes()">Cerrara</plex-button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<plex-button size="sm" type="danger" (click)="cerrarCargarPacientes()">Cerrara</plex-button>
<plex-button size="sm" type="danger" (click)="cerrarCargarPacientes()">Cerrar</plex-button>

@liquid36
Copy link
Contributor

USUARIO: plammel
BUILD NUMBER: 5709
CYPRESS RUN: 4633
TEST START: 2021-12-22T18:01:49.058Z
TOTAL: 404
SUCCESS: 384
FAIL: 19
SKIPPED: 1

Copy link
Contributor

@martinebucarey martinebucarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisar que hay casos donde no se estan setenado los id de los pacientes en el turno y por ese motivo se asignan los turnos pero no se muestran en el sidebar

@plammel plammel force-pushed the CIT-134b branch 2 times, most recently from 3b14179 to ae64c84 Compare February 15, 2022 14:47
@plammel
Copy link
Contributor Author

plammel commented Feb 15, 2022

Por alguna razon esta guardando vacio el array de queries cuando creo la agenda, adjunto las imagenes de lo que tiene la agenda y como esta en la base el concepto, lo probe en demo y local y me pasa lo mismo

imagen imagen

updated!

@liquid36
Copy link
Contributor

USUARIO: martinebucarey
BUILD NUMBER: 5931
CYPRESS RUN: 4848
TEST START: 2022-02-15T17:11:09.922Z
TOTAL: 404
SUCCESS: 402
FAIL: 1
SKIPPED: 1

@liquid36
Copy link
Contributor

USUARIO: martinebucarey
BUILD NUMBER: 5932
CYPRESS RUN: 4849
TEST START: 2022-02-15T17:20:46.572Z
TOTAL: 404
SUCCESS: 402
FAIL: 1
SKIPPED: 1

Copy link
Contributor

@martinebucarey martinebucarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En el caso de tener permisos para todas las queries, el componente se rompe porque quiere mandar un _id=*
imagen

@liquid36
Copy link
Contributor

USUARIO: martinebucarey
BUILD NUMBER: 5940
CYPRESS RUN: 4857
TEST START: 2022-02-17T15:53:29.556Z
TOTAL: 343
SUCCESS: 331
FAIL: 11
SKIPPED: 1

@liquid36
Copy link
Contributor

USUARIO: martinebucarey
BUILD NUMBER: 5941
CYPRESS RUN: 4858
TEST START: 2022-02-17T16:03:17.174Z
TOTAL: 406
SUCCESS: 404
FAIL: 1
SKIPPED: 1

@liquid36
Copy link
Contributor

USUARIO: martinebucarey
BUILD NUMBER: 5942
CYPRESS RUN: 4859
TEST START: 2022-02-17T16:49:59.340Z
TOTAL: 406
SUCCESS: 405
FAIL: 0
SKIPPED: 1

@liquid36 liquid36 added test ok Los test estan ok and removed test fail labels Feb 17, 2022
@martinebucarey martinebucarey merged commit 4543322 into master Feb 17, 2022
@martinebucarey martinebucarey deleted the CIT-134b branch February 17, 2022 16:52
liquid36 pushed a commit that referenced this pull request Feb 23, 2022
# [5.85.0](v5.84.0...v5.85.0) (2022-02-23)

### Features

* **citas:** carga masiva ([#2526](#2526)) ([4543322](4543322))
* **ficha:** nuevos tipos de confirmacion ([#2586](#2586)) ([aba5629](aba5629))
* **vacunas:** nueva pantalla verificar estado ([#2584](#2584)) ([c22e1e5](c22e1e5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test ok Los test estan ok
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants