IN - Permitir anular prestaciones de internación #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinebucarey
requested changes
May 19, 2022
| @@ -127,7 +131,7 @@ export class RegistrosHudsDetalleComponent implements OnInit { | |||
| if (tipoPrestacion) { | |||
| return fecha.isSameOrBefore(hasta, 'd') && fecha.isSameOrAfter(desde, 'd') && tipoPrestacion.conceptId === prestacion.solicitud.tipoPrestacion.conceptId; | |||
| } | |||
| return fecha.isSameOrBefore(hasta, 'd') && fecha.isSameOrAfter(desde, 'd'); | |||
| return fecha.isSameOrBefore(hasta, 'd') && fecha.isSameOrAfter(desde, 'd') && (this.prestacionesEliminadas.findIndex(id => id === prestacion.id) === -1); | |||
There was a problem hiding this comment.
si se quiere saber si existe en un array un elemento dada una condicion, usar some():
https://developer.mozilla.org/es/docs/Web/JavaScript/Reference/Global_Objects/Array/some
There was a problem hiding this comment.
Corregido!
| @@ -115,8 +115,12 @@ export class RegistrosHudsDetalleComponent implements OnInit { | |||
| this.hasta$, | |||
| this.tipoPrestacion$, | |||
| this.min$, | |||
| this.refresh$ | |||
There was a problem hiding this comment.
Es medio confuso el nombre refresh$ si solo es un id de la prestacion que se usa para que se dispare el combineLatest, por ahi le pondria un nombre mas referido a lo que guarda
There was a problem hiding this comment.
Corregido!
|
Resolver conflictos |
1 similar comment
|
Resolver conflictos |
|
Resolver conflictos para subir |
MarianoCampetella
force-pushed
the
IN-430
branch
from
6054405
to
2bf2602
Compare
Resuelto! |
martinebucarey
approved these changes
Jun 30, 2022
MCele
approved these changes
Jul 1, 2022
liquid36
pushed a commit
that referenced
this pull request
Jul 6, 2022
# [5.100.0](v5.99.1...v5.100.0) (2022-07-06) ### Bug Fixes * **plan-indiciaciones:** scroll grilla ([#2695](#2695)) ([b6e0a41](b6e0a41)) ### Features * **CITAS:** agrega nombre del dia en listado de agendas ([#2681](#2681)) ([e1c2727](e1c2727)) * **IN-430:** Permitir anular prestaciones de internacion ([#2658](#2658)) ([c1ab483](c1ab483)) * **IN-442:** Labels de resultados en pantalla de censos ([#2672](#2672)) ([aef3a26](aef3a26)) * **INTERNACION:** cambio de lugar botones ([#2692](#2692)) ([599039f](599039f)) * **MISC-225:** Agregar filtro por conceptos en el reporte c2 ([#2634](#2634)) ([a4b9904](a4b9904)) * **RUP:** cambio condicion de required ([#2694](#2694)) ([89ec7f6](89ec7f6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/IN-430
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion