Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOP - Reemplaza colores de badges en solicitudes #2806

Merged
merged 1 commit into from
Mar 3, 2023
Merged

TOP - Reemplaza colores de badges en solicitudes #2806

merged 1 commit into from
Mar 3, 2023

Conversation

ma7payne
Copy link
Contributor

Requerimiento

https://proyectos.andes.gob.ar/browse/TOP-148

Funcionalidad desarrollada

  1. Se aplica mockup para colores de bagdes en solicitudes
  2. Se implementa estructura para obtener estados correctos de solicitud con sus colores
  3. Se realiza una limpieza en el código para reducir condicionales

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

  • Si
  • No

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@ma7payne ma7payne requested review from a team as code owners January 13, 2023 19:16
@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8266
CYPRESS RUN: 7447
TEST START: 2023-01-17T19:51:03.449Z
TOTAL: 406
SUCCESS: 399
FAIL: 5
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: mchiappe
BUILD NUMBER: 8268
CYPRESS RUN: 7449
TEST START: 2023-01-18T13:18:24.182Z
TOTAL: 406
SUCCESS: 397
FAIL: 7
SKIPPED: 2

negro89
negro89 reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@negro89 negro89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funciona de 10, pero para no repetir código y que se pueda usar desde cualquier lugar de la app creo que lo mejor seria implementar un pipe. Hay ejemplos en el mismo modulo: botones.pipe o estado-solicitud.pipe.

@negro89 negro89 added the changes requested Se solicitaron cambios label Jan 18, 2023
@ma7payne
Copy link
Contributor Author

Considerando el uso de pipes como mencionaba @negro89 , se implementa EstadoPrestacionPipe (estadoPrestacion) y se eliminan los objetos "nombreEstados" + "tipoEstados".
Al no estar "nombreEstados" se restablecen condicionales previas en solicitudes.html y detalleSolicitud.html, para tener en cuenta casos como los de "Turno Dado" o "Contrarreferida".

Quedo atento.

@silviroa
Copy link
Contributor

USUARIO: mchiappe
BUILD NUMBER: 8283
CYPRESS RUN: 7464
TEST START: 2023-01-19T15:00:47.509Z
TOTAL: 406
SUCCESS: 401
FAIL: 3
SKIPPED: 2

@negro89 negro89 added changes done and removed changes requested Se solicitaron cambios labels Jan 20, 2023
negro89
negro89 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@negro89 negro89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maravilloso 🥇

@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8304
CYPRESS RUN: 7483
TEST START: 2023-01-20T18:50:25.388Z
TOTAL: 406
SUCCESS: 403
FAIL: 1
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8305
CYPRESS RUN: 7484
TEST START: 2023-01-20T19:02:13.995Z
TOTAL: 406
SUCCESS: 402
FAIL: 2
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8466
CYPRESS RUN: 7641
TEST START: 2023-02-28T13:02:37.784Z
TOTAL: 405
SUCCESS: 394
FAIL: 9
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8467
CYPRESS RUN: 7642
TEST START: 2023-02-28T13:18:04.087Z
TOTAL: 406
SUCCESS: 403
FAIL: 1
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 8468
CYPRESS RUN: 7643
TEST START: 2023-02-28T13:39:18.214Z
TOTAL: 406
SUCCESS: 395
FAIL: 9
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Mar 2, 2023

USUARIO: lmlagos
BUILD NUMBER: 8493
CYPRESS RUN: 7672
TEST START: 2023-03-02T13:31:09.785Z
TOTAL: 376
SUCCESS: 365
FAIL: 9
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Mar 2, 2023

USUARIO: lmlagos
BUILD NUMBER: 8494
CYPRESS RUN: 7673
TEST START: 2023-03-02T13:41:49.691Z
TOTAL: 388
SUCCESS: 385
FAIL: 1
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Mar 2, 2023

USUARIO: lmlagos
BUILD NUMBER: 8495
CYPRESS RUN: 7674
TEST START: 2023-03-02T13:54:45.814Z
TOTAL: 406
SUCCESS: 403
FAIL: 1
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Mar 2, 2023

USUARIO: lmlagos
BUILD NUMBER: 8497
CYPRESS RUN: 7676
TEST START: 2023-03-02T14:19:31.950Z
TOTAL: 356
SUCCESS: 352
FAIL: 2
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Mar 2, 2023

USUARIO: lmlagos
BUILD NUMBER: 8499
CYPRESS RUN: 7678
TEST START: 2023-03-02T14:44:50.099Z
TOTAL: 376
SUCCESS: 366
FAIL: 8
SKIPPED: 2

@silviroa
Copy link
Contributor

silviroa commented Mar 2, 2023

USUARIO: lmlagos
BUILD NUMBER: 8506
CYPRESS RUN: 7685
TEST START: 2023-03-02T16:12:37.899Z
TOTAL: 406
SUCCESS: 404
FAIL: 0
SKIPPED: 2

@silviroa silviroa added test ok Los test estan ok and removed test fail labels Mar 2, 2023
@negro89 negro89 merged commit 3eba161 into master Mar 3, 2023
@negro89 negro89 deleted the TOP-148 branch March 3, 2023 12:36
liquid36 pushed a commit that referenced this pull request Mar 8, 2023
@semantic-release-bot
chore(release): 5.115.0 [skip ci]
7ba095c 
# [5.115.0](v5.114.1...v5.115.0) (2023-03-08)

### Bug Fixes

* **RUP:** cambio del calulo de la edad gestacional ([#2739](#2739)) ([4f06142](4f06142))
* **RUP:** Componente numerico se quita valor por defecto 0 ([#2824](#2824)) ([527fc87](527fc87))
* **TOP:** corrige filtro por estado bandeja salida ([#2825](#2825)) ([c60f720](c60f720))

### Features

* **HUDS:** agrega historial de turnos de paciente ([#2818](#2818)) ([3a7ae97](3a7ae97))
* **INT:** registra eventos solo validadas ([#2708](#2708)) ([d74d790](d74d790))
* **TOP:** modifica badges de solicitudes con pipe ([#2806](#2806)) ([3eba161](3eba161))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgosLizzi AgosLizzi AgosLizzi approved these changes

@MarianoCampetella MarianoCampetella MarianoCampetella approved these changes

@negro89 negro89 negro89 approved these changes

@MCele MCele Awaiting requested review from MCele MCele is a code owner automatically assigned from andes/code-review

Assignees
No one assigned
Labels
Aprobado test ok Los test estan ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ma7payne @silviroa @MarianoCampetella @negro89 @AgosLizzi