fixes #19
Merged
fixes #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andhus
approved these changes
Apr 8, 2024
| @@ -132,7 +132,7 @@ def test_ignore_extensions(self): | |||
|
|
|||
| class TempDirTest(object): | |||
|
|
|||
| def setup(self): | |||
| def setup_method(self): | |||
| self.dir = tempfile.mkdtemp() | |||
|
|
|||
| def tear_down(self): | |||
There was a problem hiding this comment.
looks like this should also be teardown_method :) https://docs.pytest.org/en/stable/how-to/xunit_setup.html
andhus
reviewed
Apr 8, 2024
| @@ -26,7 +26,7 @@ | |||
| author="Anders Huss", | |||
| author_email="andhus@kth.se", | |||
| license='MIT', | |||
| install_requires=['scantree>=0.0.1'], | |||
| install_requires=['scantree>=0.0.2', 'pathspec<=0.10.0'], | |||
There was a problem hiding this comment.
In fact pathspec==0.10.0 was "yanked" of pypi https://pypi.org/project/pathspec/0.10.0/ so this should really be <0.10.0 to be clear. Will fix in #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andhus these changes are pointed to your PR #17, feel free to merge it in anytime
they should help you to have a safe commit to create a new release
I'll probably try to contribute some more, but right now i need that removal of pkg_resources released for a project of my own, thx in advance