Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Mathias-Fiege-Änderungen-2021-01-01 #165

Closed
wants to merge 1 commit into from

Conversation

NoGAD-de
Copy link

@NoGAD-de NoGAD-de commented Jan 1, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

What changes did you make? (Give an overview)

  1. Add new template: trm-transparenz
  2. Add new fixed save-button in config
  3. Add header-language in config
  4. Changed hidden admin handler from /admin to /login
  5. Add toggle decorate lines
  6. Add toggle use title and subtext

Bug Fixes:

  1. Change hidden user-login from right to left (gallery button wasnt useable if transparenz is set)
  2. Deleted some obsolete css-properties

Is there anything you'd like reviewers to focus on?

@@ -158,6 +159,27 @@
</div>
</div>

<div style="position:sticky; width:225px; bottom:10px;">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Css should be moved to sass

@andi34
Copy link
Owner

andi34 commented Jan 1, 2021

First of all thanks for your contribution!
Seeks like the css changes are missing. Have you changed the css files? For development changes to the css files needs to be done inside src/sass/. You can create another commit with it and push it to the same branch to be added to this PR. Let me know if you need any help with it.

@andi34
Copy link
Owner

andi34 commented Jan 17, 2021

Hey Mathias!
If you like you can send me the css files and I'll take a look to add your changes to the .scss files.

Best regards

Andi

@andi34 andi34 closed this Feb 8, 2021
@andi34
Copy link
Owner

andi34 commented Feb 8, 2021

Thanks for your contribution. ill take parts of it for next release.
If you like to add the missing sass files feel free to reopen the PR.

andi34 added a commit that referenced this pull request Mar 1, 2021
- has been part of #165,
  slightly updated

Change-Id: I51883d6c5f7a31bbe4eea6430fd4c680e52fdf3d
andi34 added a commit that referenced this pull request Mar 1, 2021
- has been part of #165,
  slightly updated

Change-Id: Ie783b3e4d91c01179943eda1de2ea78e97bdf7ca
andi34 added a commit that referenced this pull request Mar 1, 2021
- has been part of #165,
  slightly updated

Change-Id: I51883d6c5f7a31bbe4eea6430fd4c680e52fdf3d
andi34 added a commit that referenced this pull request Mar 1, 2021
- has been part of #165,
  slightly updated

Change-Id: Ie783b3e4d91c01179943eda1de2ea78e97bdf7ca
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants