This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
implement countdown offset to compensate shutter-delay and cheese time #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
I noticed, that some users that wanted to take pictures with the photobooth seemed to be confused or misled on the time the picture is taken. They assumed that at the moment the box displays "Cheeeeeese" and the live preview hides the image gets taken. This is probably encouraged by the mirror of the DSLR going down between live view and taking the picture.
A colleague suggested changing the countdown in a way, that it reaches 0 at the approximate time the photo is really taken. I implemented it using an offset that is added to the displayed countdown. It looks like this now
6, 5, 4, 3, Cheeeeeese [1 second] + shutter delay + Autofocus [1-2 seconds]
In my opinion, it is more intuitive this way. I would be glad to hear your opinion.
Is there anything you'd like reviewers to focus on?