Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

stabilized rotary encoder handling #449

Merged
merged 1 commit into from
Jun 16, 2022
Merged

stabilized rotary encoder handling #449

merged 1 commit into from
Jun 16, 2022

Conversation

andi34
Copy link
Owner

@andi34 andi34 commented Jun 15, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • New feature

What changes did you make? (Give an overview)

  • Stabilized rotary encoder function (Jump on every third "turn-click" to next button)

Is there anything you'd like reviewers to focus on?

Cleaned up #441

Change-Id: If5678c7a1f8be7fe9c9e64773583246cbc92fb0e
Copy link
Collaborator

@jacques42 jacques42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - makes sense to me and seems like you also fixed another bug (where I confused Pins in the code). In a future release I will make 'cnt' a slider in the expert settings of admin for rotary and name it 'sensitivity'. So people can adjust depending on their Hardware rotary switch

@andi34 andi34 merged commit fafb5bf into dev Jun 16, 2022
@andi34 andi34 deleted the fix/rotary-encoder branch June 16, 2022 10:03
@DIY89
Copy link

DIY89 commented Jun 16, 2022

Yeah - that's a really good idea to integrate a slider to expert view. I also thought about this solution.

marco-117 added a commit to marco-117/photobooth that referenced this pull request Aug 2, 2022
Bug fixed: in pull request  andi34#449 the direction detection was override by the same pin. 

Update: when changing the direction, you may have to make more than 3 clicks. By resetting the counter on the first click in the new dirction this problem is solved.
andi34 pushed a commit that referenced this pull request Aug 5, 2022
Bug fixed: in pull request  #449 the direction detection was override by the same pin.

Update: when changing the direction, you may have to make more than 3 clicks. By resetting the counter on the first click in the new dirction this problem is solved.
Change-Id: If41f60a9f8aa5c005e9afdc37bc640e3f157b355
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants