Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old rnpm for react-native 0.60 #361

Merged
merged 16 commits into from
Aug 22, 2019
Merged

Conversation

carlosroberto555
Copy link
Contributor

I have folow this migration guide for fix the rn60 warning
I don't have time to test this change yet, but I accept any feedbacks
#359

@brodycj
Copy link
Contributor

brodycj commented Jul 16, 2019

Looks nice, I will try to test it later today.

I would favor that we keep the existing rnpm entry for now, so that people can continue using React Native pre-0.60 for a while.

@carlosroberto555
Copy link
Contributor Author

carlosroberto555 commented Jul 16, 2019

I found this part of migration guide and fixed the react-native.config.js

Copy link
Owner

@andpor andpor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat using 2 spaces for tabs.

@carlosroberto555
Copy link
Contributor Author

How we can do android link with react-native link?
Anybody has the answer?

@carlosroberto555
Copy link
Contributor Author

carlosroberto555 commented Jul 17, 2019

Looks nice, I will try to test it later today.

I would favor that we keep the existing rnpm entry for now, so that people can continue using React Native pre-0.60 for a while.

@brodybits I had read on migration guide, and see this info:

"rnpm" is deprecated and support for it will be removed in next major version of the CLI.

It's not because react-native version, but the cli version, since react-native ^0.59 they are independent.
New versions of react-native-cli show this warning and version 2.0.0 is not compatible.
But we can create a support branch for old versions of react-native that uses rnpm yet.
You can see more info here.

@carlosroberto555
Copy link
Contributor Author

@andpor any more changes request?

@crobinson42
Copy link

+1 can we help move this along in any way?

@carlosroberto555
Copy link
Contributor Author

I'll create a another npm package for solve this problem.
This PR has more a month, and not had activity.

@crobinson42
Copy link

crobinson42 commented Aug 21, 2019 via email

@carlosroberto555
Copy link
Contributor Author

Yes not solve, it's only a idea
This workaround install from my fork directly.

yarn add carlosroberto555/react-native-sqlite-storage

I used on my personal project, and autolink works like a charm.

@andpor andpor merged commit 24d0182 into andpor:master Aug 22, 2019
@andpor
Copy link
Owner

andpor commented Aug 22, 2019

The PR is merged and released under 4.0.0 - sorry for delay, quite busy lately. 4.0.0 has been published to npm.

@mikehardy
Copy link

The burden on library maintainers for react-native 0.60 (both in their paying project work, and whatever libraries they maintain) is pretty serious, and it's vacation season - glad to see this merged but everyone be as helpful as you can in the libraries you use, pretty much like submitting the PR here (❤️) and being patient. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants